netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Maciej Żenczykowski" <zenczykowski@gmail.com>
To: "Maciej Żenczykowski" <maze@google.com>,
	"Pablo Neira Ayuso" <pablo@netfilter.org>,
	"Florian Westphal" <fw@strlen.de>
Cc: Linux Network Development Mailing List <netdev@vger.kernel.org>,
	Netfilter Development Mailing List 
	<netfilter-devel@vger.kernel.org>
Subject: [PATCH] libip6t_srh.t: switch to lowercase, add /128 suffix, require success
Date: Mon, 11 May 2020 14:33:49 -0700	[thread overview]
Message-ID: <20200511213349.248618-1-zenczykowski@gmail.com> (raw)

From: Maciej Żenczykowski <maze@google.com>

This looks like an oversight which is easy to fix.

Furthermore:
  git grep ';;OK'
does not find any other matches, so this is the last unverified test case.

Test:
  [root@f32vm IPT]# uname -r
  5.6.10-300.fc32.x86_64

  [root@f32vm IPT]# md5sum extensions/libip6t_srh.t
  b98864bdd6c39a0dd96022c47e652edb  extensions/libip6t_srh.t

  [root@f32vm IPT]# ./iptables-test.py extensions/libip6t_srh.t
  extensions/libip6t_srh.t: OK
  1 test files, 27 unit tests, 27 passed

Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
 extensions/libip6t_srh.t | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/extensions/libip6t_srh.t b/extensions/libip6t_srh.t
index 07b54031..5b02a71b 100644
--- a/extensions/libip6t_srh.t
+++ b/extensions/libip6t_srh.t
@@ -23,6 +23,6 @@
 -m srh ! --srh-tag 0;=;OK
 -m srh --srh-next-hdr 17 --srh-segs-left-eq 1 --srh-last-entry-eq 4 --srh-tag 0;=;OK
 -m srh ! --srh-next-hdr 17 ! --srh-segs-left-eq 0 --srh-tag 0;=;OK
--m srh --srh-psid A::/64 --srh-nsid B:: --srh-lsid C::/0;;OK
--m srh ! --srh-psid A::/64 ! --srh-nsid B:: ! --srh-lsid C::/0;;OK
+-m srh --srh-psid a::/64 --srh-nsid b::/128 --srh-lsid c::/0;=;OK
+-m srh ! --srh-psid a::/64 ! --srh-nsid b::/128 ! --srh-lsid c::/0;=;OK
 -m srh;=;OK
-- 
2.26.2.645.ge9eca65c58-goog


             reply	other threads:[~2020-05-11 21:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 21:33 Maciej Żenczykowski [this message]
2020-05-14 12:25 ` [PATCH] libip6t_srh.t: switch to lowercase, add /128 suffix, require success Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200511213349.248618-1-zenczykowski@gmail.com \
    --to=zenczykowski@gmail.com \
    --cc=fw@strlen.de \
    --cc=maze@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).