From: David Miller <davem@davemloft.net>
To: ecree@solarflare.com
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
jiri@resnulli.us, kuba@kernel.org, pablo@netfilter.org
Subject: Re: [PATCH v4 net-next] net: flow_offload: simplify hw stats check handling
Date: Fri, 22 May 2020 15:52:20 -0700 (PDT) [thread overview]
Message-ID: <20200522.155220.1541483265983849619.davem@davemloft.net> (raw)
In-Reply-To: <0f0e052c-fa79-2ac7-8cec-98d4908845d0@solarflare.com>
From: Edward Cree <ecree@solarflare.com>
Date: Wed, 20 May 2020 19:18:10 +0100
> Make FLOW_ACTION_HW_STATS_DONT_CARE be all bits, rather than none, so that
> drivers and __flow_action_hw_stats_check can use simple bitwise checks.
>
> Pre-fill all actions with DONT_CARE in flow_rule_alloc(), rather than
> relying on implicit semantics of zero from kzalloc, so that callers which
> don't configure action stats themselves (i.e. netfilter) get the correct
> behaviour by default.
>
> Only the kernel's internal API semantics change; the TC uAPI is unaffected.
>
> v4: move DONT_CARE setting to flow_rule_alloc() for robustness and simplicity.
>
> v3: set DONT_CARE in nft and ct offload.
>
> v2: rebased on net-next, removed RFC tags.
>
> Signed-off-by: Edward Cree <ecree@solarflare.com>
Applied, thanks Edward.
prev parent reply other threads:[~2020-05-22 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 18:18 [PATCH v4 net-next] net: flow_offload: simplify hw stats check handling Edward Cree
2020-05-22 22:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522.155220.1541483265983849619.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).