From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16434C433E0 for ; Tue, 26 May 2020 22:00:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0D6F20707 for ; Tue, 26 May 2020 22:00:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390966AbgEZV76 (ORCPT ); Tue, 26 May 2020 17:59:58 -0400 Received: from correo.us.es ([193.147.175.20]:59812 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389342AbgEZV76 (ORCPT ); Tue, 26 May 2020 17:59:58 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 136701C4388 for ; Tue, 26 May 2020 23:59:56 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 03CB6DA718 for ; Tue, 26 May 2020 23:59:56 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id EAF6DDA710; Tue, 26 May 2020 23:59:55 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 040BADA701; Tue, 26 May 2020 23:59:54 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 26 May 2020 23:59:54 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id CFE3942EF42A; Tue, 26 May 2020 23:59:53 +0200 (CEST) Date: Tue, 26 May 2020 23:59:53 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Sriharsha Basavapatna Cc: netfilter-devel@vger.kernel.org, David Miller , netdev@vger.kernel.org, paulb@mellanox.com, Oz Shlomo , vladbu@mellanox.com, jiri@resnulli.us, kuba@kernel.org, saeedm@mellanox.com, Michael Chan Subject: Re: [PATCH 7/8 net] bnxt_tc: update indirect block support Message-ID: <20200526215953.GA3089@salvia> References: <20200513164140.7956-1-pablo@netfilter.org> <20200513164140.7956-8-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi, I overlook this email, sorry. On Tue, May 19, 2020 at 02:23:54PM +0530, Sriharsha Basavapatna wrote: [...] > > @@ -2101,7 +2073,8 @@ void bnxt_shutdown_tc(struct bnxt *bp) > > if (!bnxt_tc_flower_enabled(bp)) > > return; > > > > - unregister_netdevice_notifier(&bp->tc_netdev_nb); > > + flow_indr_dev_unregister(bnxt_tc_setup_indr_cb, bp, > > + bnxt_tc_setup_indr_block_cb); > > Why does the driver need to provide the "cb" again during unregister, > since both "cb" and "cb_priv" are already provided during register() ? > This interface could be simplified/improved if > flow_indr_dev_register() returns an opaque handle to the object it > creates (struct flow_indr_dev *) ? Probably, at the expense to storing this in the netdev private area. > The driver should just pass this > handle during unregistration. Also, why do we need the extra (3rd) > argument (flow_setup_cb_t / bnxt_tc_setup_indr_block_cb) during unreg > ? It is handled internally by the driver as a part of FLOW_BLOCK_BIND > / UNBIND ? flow_indr_dev_unregister() needs bnxt_tc_setup_indr_block_cb to identify what indirect flow_blocks need to be cleaned up before this representor is gone.