Re: [PATCH 1/1] Restore the CT mark in Flow Offload

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2624 bytes --]

Hi Sven,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nf/master]
[also build test ERROR on nf-next/master linus/master v5.7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Sven-Auhagen/Restore-the-CT-mark-in-Flow-Offload/20200523-184803
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: i386-randconfig-a011-20200601 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2388a096e7865c043e83ece4e26654bd3d1a20d5)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install i386 cross compiling tool for clang build
        # apt-get install binutils-i386-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>, old ones prefixed by <<):

>> net/netfilter/nf_flow_table_core.c:325:25: error: no member named 'mark' in 'struct nf_conn'
skb->mark = flow->ct->mark;
~~~~~~~~  ^
1 error generated.

vim +325 net/netfilter/nf_flow_table_core.c

   300	
   301	struct flow_offload_tuple_rhash *
   302	flow_offload_lookup(struct nf_flowtable *flow_table,
   303			    struct flow_offload_tuple *tuple,
   304			    struct sk_buff *skb)
   305	{
   306		struct flow_offload_tuple_rhash *tuplehash;
   307		struct flow_offload *flow;
   308		int dir;
   309	
   310		tuplehash = rhashtable_lookup(&flow_table->rhashtable, tuple,
   311					      nf_flow_offload_rhash_params);
   312		if (!tuplehash)
   313			return NULL;
   314	
   315		dir = tuplehash->tuple.dir;
   316		flow = container_of(tuplehash, struct flow_offload, tuplehash[dir]);
   317		if (test_bit(NF_FLOW_TEARDOWN, &flow->flags))
   318			return NULL;
   319	
   320		if (unlikely(nf_ct_is_dying(flow->ct)))
   321			return NULL;
   322	
   323		/* Restore Mark for TC */
   324		if (skb)
 > 325			skb->mark = flow->ct->mark;
   326	
   327		return tuplehash;
   328	}
   329	EXPORT_SYMBOL_GPL(flow_offload_lookup);
   330	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48165 bytes --]