From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Giuseppe Scrivano <gscrivan@redhat.com>
Cc: netfilter-devel@vger.kernel.org, Phil Sutter <phil@nwl.cc>,
Florian Westphal <fw@strlen.de>
Subject: Re: [iptables PATCH v3] iptables: accept lock file name at runtime
Date: Fri, 17 Jul 2020 12:22:43 +0200 [thread overview]
Message-ID: <20200717102243.GB18560@salvia> (raw)
In-Reply-To: <87wo32v4at.fsf@redhat.com>
On Fri, Jul 17, 2020 at 12:12:10PM +0200, Giuseppe Scrivano wrote:
> Hi Pablo,
>
> Pablo Neira Ayuso <pablo@netfilter.org> writes:
>
> > Probably remove the check for lock_file[0] == '\0'
> >
> > Or is this intentional?
>
> I've added it intentionally as I think it is safer to ignore an empty
> string. The programs I've checked, GNU coreutils and GNU grep, have the
> same check.
Thanks for explaining.
> The empty string will likely fail on open(2), at least on tmpfs
> it does with ENOENT. If you want though, I can drop the check.
No worries, patch description did not explain this and quick git grep
on iptables was showing no check for \0 in other spots in the tree. No
need to drop the check.
next prev parent reply other threads:[~2020-07-17 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 8:39 [iptables PATCH v3] iptables: accept lock file name at runtime Giuseppe Scrivano
2020-07-17 9:27 ` Pablo Neira Ayuso
2020-07-17 10:12 ` Giuseppe Scrivano
2020-07-17 10:22 ` Pablo Neira Ayuso [this message]
2020-07-24 11:21 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717102243.GB18560@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=gscrivan@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).