From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA304C433E5 for ; Tue, 28 Jul 2020 18:17:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A87282070B for ; Tue, 28 Jul 2020 18:17:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728904AbgG1SRR (ORCPT ); Tue, 28 Jul 2020 14:17:17 -0400 Received: from correo.us.es ([193.147.175.20]:41596 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728755AbgG1SRR (ORCPT ); Tue, 28 Jul 2020 14:17:17 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 35FC615AEB1 for ; Tue, 28 Jul 2020 20:17:16 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 25275DA73F for ; Tue, 28 Jul 2020 20:17:16 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 1AF21DA73D; Tue, 28 Jul 2020 20:17:16 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 2A722DA73F for ; Tue, 28 Jul 2020 20:17:14 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 28 Jul 2020 20:17:14 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from localhost.localdomain (unknown [90.77.255.23]) (Authenticated sender: pneira@us.es) by entrada.int (Postfix) with ESMTPA id 0DD8B4265A2F for ; Tue, 28 Jul 2020 20:17:14 +0200 (CEST) X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Subject: [PATCH nft 2/3] evaluate: memleak in invalid default policy definition Date: Tue, 28 Jul 2020 20:17:09 +0200 Message-Id: <20200728181710.14919-2-pablo@netfilter.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200728181710.14919-1-pablo@netfilter.org> References: <20200728181710.14919-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Release the clone expression from the exit path. Fixes: 5173151863d3 ("evaluate: replace variable expression by the value expression") Signed-off-by: Pablo Neira Ayuso --- src/evaluate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/evaluate.c b/src/evaluate.c index e529a7f08e14..536325e83537 100644 --- a/src/evaluate.c +++ b/src/evaluate.c @@ -2017,8 +2017,10 @@ static int expr_evaluate_variable(struct eval_ctx *ctx, struct expr **exprp) { struct expr *new = expr_clone((*exprp)->sym->expr); - if (expr_evaluate(ctx, &new) < 0) + if (expr_evaluate(ctx, &new) < 0) { + expr_free(new); return -1; + } expr_free(*exprp); *exprp = new; -- 2.20.1