[PATCH nf] netfilter: nft_meta: fix iifgroup matching

[PATCH nf] netfilter: nft_meta: fix iifgroup matching

[Florian Westphal]

iifgroup matching errounously checks the output interface.

Fixes: 8724e819cc9a ("netfilter: nft_meta: move all interface related keys to helper")
Reported-by: Demi M. Obenour <demiobenour@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
---
 net/netfilter/nft_meta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nft_meta.c b/net/netfilter/nft_meta.c
index 951b6e87ed5d..7bc6537f3ccb 100644
--- a/net/netfilter/nft_meta.c
+++ b/net/netfilter/nft_meta.c
@@ -253,7 +253,7 @@ static bool nft_meta_get_eval_ifname(enum nft_meta_keys key, u32 *dest,
 			return false;
 		break;
 	case NFT_META_IIFGROUP:
-		if (!nft_meta_store_ifgroup(dest, nft_out(pkt)))
+		if (!nft_meta_store_ifgroup(dest, nft_in(pkt)))
 			return false;
 		break;
 	case NFT_META_OIFGROUP:
-- 
2.26.2

Re: [PATCH nf] netfilter: nft_meta: fix iifgroup matching

[Pablo Neira Ayuso]

On Sun, Aug 02, 2020 at 03:27:03AM +0200, Florian Westphal wrote:
> iifgroup matching errounously checks the output interface.

Applied, thanks.

Re: [PATCH nf] netfilter: nft_meta: fix iifgroup matching

[Demi M. Obenour]

[-- Attachment #1.1: Type: text/plain, Size: 284 bytes --]

On 2020-08-01 21:49, Pablo Neira Ayuso wrote:
> On Sun, Aug 02, 2020 at 03:27:03AM +0200, Florian Westphal wrote:
>> iifgroup matching errounously checks the output interface.
> 
> Applied, thanks.

Would you mind also marking this for backport to 5.7?

Thank you,

Demi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]