Netfilter-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH nf] netfilter: nft_meta: fix iifgroup matching
@ 2020-08-02  1:27 Florian Westphal
  2020-08-02  1:49 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 3+ messages in thread
From: Florian Westphal @ 2020-08-02  1:27 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Florian Westphal, Demi M . Obenour

iifgroup matching errounously checks the output interface.

Fixes: 8724e819cc9a ("netfilter: nft_meta: move all interface related keys to helper")
Reported-by: Demi M. Obenour <demiobenour@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
---
 net/netfilter/nft_meta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nft_meta.c b/net/netfilter/nft_meta.c
index 951b6e87ed5d..7bc6537f3ccb 100644
--- a/net/netfilter/nft_meta.c
+++ b/net/netfilter/nft_meta.c
@@ -253,7 +253,7 @@ static bool nft_meta_get_eval_ifname(enum nft_meta_keys key, u32 *dest,
 			return false;
 		break;
 	case NFT_META_IIFGROUP:
-		if (!nft_meta_store_ifgroup(dest, nft_out(pkt)))
+		if (!nft_meta_store_ifgroup(dest, nft_in(pkt)))
 			return false;
 		break;
 	case NFT_META_OIFGROUP:
-- 
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH nf] netfilter: nft_meta: fix iifgroup matching
  2020-08-02  1:27 [PATCH nf] netfilter: nft_meta: fix iifgroup matching Florian Westphal
@ 2020-08-02  1:49 ` Pablo Neira Ayuso
  2020-08-02 16:48   ` Demi M. Obenour
  0 siblings, 1 reply; 3+ messages in thread
From: Pablo Neira Ayuso @ 2020-08-02  1:49 UTC (permalink / raw)
  To: Florian Westphal; +Cc: netfilter-devel, Demi M . Obenour

On Sun, Aug 02, 2020 at 03:27:03AM +0200, Florian Westphal wrote:
> iifgroup matching errounously checks the output interface.

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH nf] netfilter: nft_meta: fix iifgroup matching
  2020-08-02  1:49 ` Pablo Neira Ayuso
@ 2020-08-02 16:48   ` Demi M. Obenour
  0 siblings, 0 replies; 3+ messages in thread
From: Demi M. Obenour @ 2020-08-02 16:48 UTC (permalink / raw)
  To: Pablo Neira Ayuso, Florian Westphal; +Cc: netfilter-devel

[-- Attachment #1.1: Type: text/plain, Size: 284 bytes --]

On 2020-08-01 21:49, Pablo Neira Ayuso wrote:
> On Sun, Aug 02, 2020 at 03:27:03AM +0200, Florian Westphal wrote:
>> iifgroup matching errounously checks the output interface.
> 
> Applied, thanks.

Would you mind also marking this for backport to 5.7?

Thank you,

Demi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02  1:27 [PATCH nf] netfilter: nft_meta: fix iifgroup matching Florian Westphal
2020-08-02  1:49 ` Pablo Neira Ayuso
2020-08-02 16:48   ` Demi M. Obenour

Netfilter-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netfilter-devel/0 netfilter-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netfilter-devel netfilter-devel/ https://lore.kernel.org/netfilter-devel \
		netfilter-devel@vger.kernel.org
	public-inbox-index netfilter-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netfilter-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git