From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH 2/5] netfilter: nft_meta: fix iifgroup matching
Date: Tue, 4 Aug 2020 22:02:05 +0200 [thread overview]
Message-ID: <20200804200208.18620-3-pablo@netfilter.org> (raw)
In-Reply-To: <20200804200208.18620-1-pablo@netfilter.org>
From: Florian Westphal <fw@strlen.de>
iifgroup matching erroneously checks the output interface.
Fixes: 8724e819cc9a ("netfilter: nft_meta: move all interface related keys to helper")
Reported-by: Demi M. Obenour <demiobenour@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/netfilter/nft_meta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nft_meta.c b/net/netfilter/nft_meta.c
index 951b6e87ed5d..7bc6537f3ccb 100644
--- a/net/netfilter/nft_meta.c
+++ b/net/netfilter/nft_meta.c
@@ -253,7 +253,7 @@ static bool nft_meta_get_eval_ifname(enum nft_meta_keys key, u32 *dest,
return false;
break;
case NFT_META_IIFGROUP:
- if (!nft_meta_store_ifgroup(dest, nft_out(pkt)))
+ if (!nft_meta_store_ifgroup(dest, nft_in(pkt)))
return false;
break;
case NFT_META_OIFGROUP:
--
2.20.1
next prev parent reply other threads:[~2020-08-04 20:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 20:02 [PATCH 0/5] Netfilter fixes for net Pablo Neira Ayuso
2020-08-04 20:02 ` [PATCH 1/5] netfilter: nft_compat: make sure xtables destructors have run Pablo Neira Ayuso
2020-08-04 20:02 ` Pablo Neira Ayuso [this message]
2020-08-04 20:02 ` [PATCH 3/5] selftests: netfilter: add meta iif/oif match test Pablo Neira Ayuso
2020-08-04 20:02 ` [PATCH 4/5] netfilter: conntrack: Move nf_ct_offload_timeout to header file Pablo Neira Ayuso
2020-08-04 20:02 ` [PATCH 5/5] netfilter: flowtable: Set offload timeout when adding flow Pablo Neira Ayuso
2020-08-04 20:32 ` [PATCH 0/5] Netfilter fixes for net David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804200208.18620-3-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).