From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Jose M. Guisado Gomez" <guigom@riseup.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nftables 3/3] src: add comment support for objects
Date: Tue, 8 Sep 2020 16:53:04 +0200 [thread overview]
Message-ID: <20200908145304.GB12366@salvia> (raw)
In-Reply-To: <20200902091241.1379-4-guigom@riseup.net>
On Wed, Sep 02, 2020 at 11:12:41AM +0200, Jose M. Guisado Gomez wrote:
> Enables specifying an optional comment when declaring named objects. The
> comment is to be specified inside the object's block ({} block)
>
> Relies on libnftnl exporting nftnl_obj_get_data and kernel space support
> to store the comments.
>
> For consistency, this patch makes the comment be printed first when
> listing objects.
>
> Adds a testcase importing all commented named objects except for secmark,
> although it's supported.
>
> Example: Adding a quota with a comment
>
> > add table inet filter
> > nft add quota inet filter q { over 1200 bytes \; comment "test_comment"\; }
> > list ruleset
>
> table inet filter {
> quota q {
> comment "test_comment"
> over 1200 bytes
> }
> }
Also applied, thanks.
prev parent reply other threads:[~2020-09-08 20:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 9:12 [PATCH 0/3] add object userdata and comment support Jose M. Guisado Gomez
2020-09-02 9:12 ` [PATCH nf-next 1/3] netfilter: nf_tables: add userdata support for nft_object Jose M. Guisado Gomez
2020-09-08 10:42 ` Pablo Neira Ayuso
2020-09-08 11:01 ` [PATCH nf-next 1/3, v2] " Jose M. Guisado Gomez
2020-09-08 14:36 ` Pablo Neira Ayuso
2020-09-02 9:12 ` [PATCH libnftnl 2/3] object: add userdata and comment support Jose M. Guisado Gomez
2020-09-08 14:52 ` Pablo Neira Ayuso
2020-09-02 9:12 ` [PATCH nftables 3/3] src: add comment support for objects Jose M. Guisado Gomez
2020-09-03 9:16 ` [PATCH nftables 3/3, v2] " Jose M. Guisado Gomez
2020-09-08 14:53 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908145304.GB12366@salvia \
--to=pablo@netfilter.org \
--cc=guigom@riseup.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).