From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AA52C4363A for ; Mon, 5 Oct 2020 21:13:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE2232078E for ; Mon, 5 Oct 2020 21:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729737AbgJEVNS (ORCPT ); Mon, 5 Oct 2020 17:13:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725861AbgJEVNS (ORCPT ); Mon, 5 Oct 2020 17:13:18 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 715E4C0613CE for ; Mon, 5 Oct 2020 14:13:18 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1kPXnI-0001N8-Qv; Mon, 05 Oct 2020 23:13:16 +0200 Date: Mon, 5 Oct 2020 23:13:16 +0200 From: Florian Westphal To: Phil Sutter Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org, Florian Westphal Subject: Re: [iptables PATCH 2/3] nft: Fix error reporting for refreshed transactions Message-ID: <20201005211316.GD5213@breakpoint.cc> References: <20201005144858.11578-1-phil@nwl.cc> <20201005144858.11578-3-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201005144858.11578-3-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > When preparing a batch from the list of batch objects in nft_action(), > the sequence number used for each object is stored within that object > for later matching against returned error messages. Though if the > transaction has to be refreshed, some of those objects may be skipped, > other objects take over their sequence number and errors are matched to > skipped objects. Avoid this by resetting the skipped object's sequence > number to zero. Reviewed-by: Florian Westphal