From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Arturo Borrero Gonzalez <arturo@netfilter.org>,
netfilter-devel@vger.kernel.org, kadlec@netfilter.org
Subject: Re: [iptables PATCH] iptables-nft: fix basechain policy configuration
Date: Fri, 9 Oct 2020 11:37:05 +0200 [thread overview]
Message-ID: <20201009093705.GF13016@orbyte.nwl.cc> (raw)
In-Reply-To: <20201009085039.GB7851@salvia>
Hi,
On Fri, Oct 09, 2020 at 10:50:39AM +0200, Pablo Neira Ayuso wrote:
[...]
> Semantics for this are: Flush out _everything_ (existing rules and
> non-chains) but only leave existing basechain policies in place as is.
>
> I wonder if this is intentional or a side effect of the --noflush support.
>
> I'm Cc'ing Jozsef, maybe he remembers. Because you're reaching my
> boundaries on the netfilter history for this one :-)
FWIW, I searched git history and can confirm the given behaviour is like
that at least since Dec 2000 and commit ae1ff9f96a803 ("make
iptables-restore and iptables-save work again!")!
iptables-legacy-restore does:
| if (noflush == 0) {
| DEBUGP("Cleaning all chains of table '%s'\n",
| table);
| cb->for_each_chain(cb->flush_entries, verbose, 1,
| handle);
|
| DEBUGP("Deleting all user-defined chains "
| "of table '%s'\n", table);
| cb->for_each_chain(cb->delete_chain, verbose, 0,
| handle);
| }
(Third parameter to for_each_chain decides whether builtins are included or
not.)
I guess fundamentally this is due to legacy design which keeps builtin
chains in place at all times. We could copy that in iptables-nft, but I
like the current design where we just delete the whole table and start
from scratch.
Florian made a related remark a while ago about flushing chains with
DROP policy: He claims it is almost always a mistake and we should reset
the policy to ACCEPT in order to avoid people from locking themselves
out. I second that idea, but am not sure if such a change is tolerable
at all.
Cheers, Phil
next prev parent reply other threads:[~2020-10-09 9:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 11:44 [iptables PATCH] iptables-nft: fix basechain policy configuration Arturo Borrero Gonzalez
2020-10-02 12:07 ` Phil Sutter
2020-10-02 12:15 ` Pablo Neira Ayuso
2020-10-02 12:28 ` Phil Sutter
2020-10-02 12:47 ` Pablo Neira Ayuso
2020-10-02 13:31 ` Phil Sutter
2020-10-02 14:39 ` Pablo Neira Ayuso
2020-10-08 17:31 ` Pablo Neira Ayuso
2020-10-09 8:29 ` Phil Sutter
2020-10-09 8:50 ` Pablo Neira Ayuso
2020-10-09 9:37 ` Phil Sutter [this message]
2020-10-09 10:07 ` Reindl Harald
2020-10-09 10:14 ` Phil Sutter
2020-10-09 10:28 ` Reindl Harald
2020-10-09 10:37 ` Jozsef Kadlecsik
2020-10-09 12:04 ` Phil Sutter
2020-10-09 19:05 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009093705.GF13016@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=arturo@netfilter.org \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).