From: Florian Westphal <fw@strlen.de>
To: Francesco Ruggeri <fruggeri@arista.com>
Cc: Florian Westphal <fw@strlen.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
open list <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH nf v2] netfilter: conntrack: connection timeout after re-register
Date: Wed, 14 Oct 2020 21:35:51 +0200 [thread overview]
Message-ID: <20201014193551.GD16895@breakpoint.cc> (raw)
In-Reply-To: <CA+HUmGij2kddxovowfK=Wt=SB6N2sTLTb1Hs+65MfrZGpv=YWg@mail.gmail.com>
Francesco Ruggeri <fruggeri@arista.com> wrote:
> On Wed, Oct 14, 2020 at 1:23 AM Florian Westphal <fw@strlen.de> wrote:
> >
> > Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > Legacy would still be flawed though.
> >
> > Its fine too, new rule blob gets handled (and match/target checkentry
> > called) before old one is dismantled.
> >
> > We only have a 0 refcount + hook unregister when rules get
> > flushed/removed explicitly.
>
> Should the patch be used in the meantime while this gets
> worked out?
I think the patch is correct, and I do NOT see a better solution.
next prev parent reply other threads:[~2020-10-14 19:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 19:32 [PATCH nf v2] netfilter: conntrack: connection timeout after re-register Francesco Ruggeri
2020-10-08 23:41 ` Francesco Ruggeri
2020-10-09 6:52 ` Jozsef Kadlecsik
2020-10-09 11:03 ` Florian Westphal
2020-10-09 18:48 ` Jozsef Kadlecsik
2020-10-09 18:55 ` Florian Westphal
2020-10-09 19:49 ` Jozsef Kadlecsik
2020-10-09 20:00 ` Francesco Ruggeri
2020-10-09 20:05 ` Florian Westphal
2020-10-14 0:06 ` Pablo Neira Ayuso
2020-10-14 8:11 ` Pablo Neira Ayuso
2020-10-14 8:23 ` Florian Westphal
2020-10-14 18:42 ` Francesco Ruggeri
2020-10-14 19:35 ` Florian Westphal [this message]
2020-10-20 15:21 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014193551.GD16895@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fruggeri@arista.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).