From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E06C433DF for ; Thu, 15 Oct 2020 15:28:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BEAF22268 for ; Thu, 15 Oct 2020 15:28:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389693AbgJOP2n (ORCPT ); Thu, 15 Oct 2020 11:28:43 -0400 Received: from correo.us.es ([193.147.175.20]:39350 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388357AbgJOP2m (ORCPT ); Thu, 15 Oct 2020 11:28:42 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id A5A921C4387 for ; Thu, 15 Oct 2020 17:28:39 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 9949BDA78F for ; Thu, 15 Oct 2020 17:28:39 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 8EB62DA78D; Thu, 15 Oct 2020 17:28:39 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 9F6C9DA78C; Thu, 15 Oct 2020 17:28:37 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 15 Oct 2020 17:28:37 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 814BA42EF4E1; Thu, 15 Oct 2020 17:28:37 +0200 (CEST) Date: Thu, 15 Oct 2020 17:28:37 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jakub Kicinski Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH net-next 9/9] netfilter: flowtable: add vlan support Message-ID: <20201015152837.GA14689@salvia> References: <20201015011630.2399-1-pablo@netfilter.org> <20201015011630.2399-10-pablo@netfilter.org> <20201015081013.4f059b7b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201015081013.4f059b7b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Oct 15, 2020 at 08:10:13AM -0700, Jakub Kicinski wrote: > On Thu, 15 Oct 2020 03:16:30 +0200 Pablo Neira Ayuso wrote: > > Add the vlan id and proto to the flow tuple to uniquely identify flows > > from the receive path. Store the vlan id and proto to set it accordingly > > from the transmit path. This patch includes support for two VLAN headers > > (Q-in-Q). > > > > Signed-off-by: Pablo Neira Ayuso > > 20+ sparse warnings here as well - do you want to respin quickly? Yes, preparing for this.