From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, Davide Caratti <dcaratti@redhat.com>
Subject: Re: [PATCH nf-next] netfilter: nftables: allow re-computing sctp CRC-32C in 'payload' statements
Date: Thu, 15 Oct 2020 18:41:25 +0200 [thread overview]
Message-ID: <20201015164125.GA28806@salvia> (raw)
In-Reply-To: <20201015161651.4902-1-fw@strlen.de>
On Thu, Oct 15, 2020 at 06:16:51PM +0200, Florian Westphal wrote:
> From: Davide Caratti <dcaratti@redhat.com>
>
> nftables payload statements are used to mangle SCTP headers, but they can
> only replace the Internet Checksum. As a consequence, nftables rules that
> mangle sport/dport/vtag in SCTP headers potentially generate packets that
> are discarded by the receiver, unless the CRC-32C is "offloaded" (e.g the
> rule mangles a skb having 'ip_summed' equal to 'CHECKSUM_PARTIAL'.
>
> Fix this extending uAPI definitions and L4 checksum update function, in a
> way that userspace programs (e.g. nft) can instruct the kernel to compute
> CRC-32C in SCTP headers. Also ensure that LIBCRC32C is built if NF_TABLES
> is 'y' or 'm' in the kernel build configuration.
I have just passed up this to net-next to help improve chances this
hits upstream in this merge window.
Thanks.
prev parent reply other threads:[~2020-10-15 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 16:16 [PATCH nf-next] netfilter: nftables: allow re-computing sctp CRC-32C in 'payload' statements Florian Westphal
2020-10-15 16:41 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015164125.GA28806@salvia \
--to=pablo@netfilter.org \
--cc=dcaratti@redhat.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).