netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: rectify file patterns for NETFILTER
@ 2020-11-09  9:19 Lukas Bulwahn
  2020-11-15 11:19 ` Pablo Neira Ayuso
  2020-11-16  3:58 ` Joe Perches
  0 siblings, 2 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2020-11-09  9:19 UTC (permalink / raw)
  To: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
	netfilter-devel, coreteam
  Cc: Ralf Ramsauer, Pia Eichinger, Joe Perches, kernel-janitors,
	linux-kernel, Lukas Bulwahn

The two file patterns in the NETFILTER section:

  F:      include/linux/netfilter*
  F:      include/uapi/linux/netfilter*

intended to match the directories:

  ./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}

A quick check with ./scripts/get_maintainer.pl --letters -f will show that
they are not matched, though, because this pattern only matches files, but
not directories.

Rectify the patterns to match the intended directories.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
applies cleanly on v5.10-rc3 and next-20201109

Pablo, Jozsef, Florian, please pick this minor non-urgent clean-up patch.

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index cba8ddf87a08..572a064a9c95 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12139,10 +12139,10 @@ W:	http://www.nftables.org/
 Q:	http://patchwork.ozlabs.org/project/netfilter-devel/list/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git
-F:	include/linux/netfilter*
+F:	include/linux/netfilter*/
 F:	include/linux/netfilter/
 F:	include/net/netfilter/
-F:	include/uapi/linux/netfilter*
+F:	include/uapi/linux/netfilter*/
 F:	include/uapi/linux/netfilter/
 F:	net/*/netfilter.c
 F:	net/*/netfilter/
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] MAINTAINERS: rectify file patterns for NETFILTER
  2020-11-09  9:19 [PATCH] MAINTAINERS: rectify file patterns for NETFILTER Lukas Bulwahn
@ 2020-11-15 11:19 ` Pablo Neira Ayuso
  2020-11-16  3:58 ` Joe Perches
  1 sibling, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2020-11-15 11:19 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Jozsef Kadlecsik, Florian Westphal, netfilter-devel, coreteam,
	Ralf Ramsauer, Pia Eichinger, Joe Perches, kernel-janitors,
	linux-kernel

On Mon, Nov 09, 2020 at 10:19:42AM +0100, Lukas Bulwahn wrote:
> The two file patterns in the NETFILTER section:
> 
>   F:      include/linux/netfilter*
>   F:      include/uapi/linux/netfilter*
> 
> intended to match the directories:
> 
>   ./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}
> 
> A quick check with ./scripts/get_maintainer.pl --letters -f will show that
> they are not matched, though, because this pattern only matches files, but
> not directories.
> 
> Rectify the patterns to match the intended directories.

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] MAINTAINERS: rectify file patterns for NETFILTER
  2020-11-09  9:19 [PATCH] MAINTAINERS: rectify file patterns for NETFILTER Lukas Bulwahn
  2020-11-15 11:19 ` Pablo Neira Ayuso
@ 2020-11-16  3:58 ` Joe Perches
  2020-11-16  9:17   ` Pablo Neira Ayuso
  1 sibling, 1 reply; 4+ messages in thread
From: Joe Perches @ 2020-11-16  3:58 UTC (permalink / raw)
  To: Lukas Bulwahn, Pablo Neira Ayuso, Jozsef Kadlecsik,
	Florian Westphal, netfilter-devel, coreteam
  Cc: Ralf Ramsauer, Pia Eichinger, kernel-janitors, linux-kernel

On Mon, 2020-11-09 at 10:19 +0100, Lukas Bulwahn wrote:
> The two file patterns in the NETFILTER section:
> 
>   F:      include/linux/netfilter*
>   F:      include/uapi/linux/netfilter*
> 
> intended to match the directories:
> 
>   ./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}
> 
> A quick check with ./scripts/get_maintainer.pl --letters -f will show that
> they are not matched, though, because this pattern only matches files, but
> not directories.
> 
> Rectify the patterns to match the intended directories.
[]
diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -12139,10 +12139,10 @@ W:	http://www.nftables.org/
>  Q:	http://patchwork.ozlabs.org/project/netfilter-devel/list/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git
> -F:	include/linux/netfilter*
> +F:	include/linux/netfilter*/
>  F:	include/linux/netfilter/

This line could be deleted or perhaps moved up one line above

F:	include/linux/netfilter/
F:	include/linux/netfilter*/

(as the second line already matches the first line's files too)

>  F:	include/net/netfilter/
> -F:	include/uapi/linux/netfilter*
> +F:	include/uapi/linux/netfilter*/
>  F:	include/uapi/linux/netfilter/

same here.

>  F:	net/*/netfilter.c
>  F:	net/*/netfilter/



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] MAINTAINERS: rectify file patterns for NETFILTER
  2020-11-16  3:58 ` Joe Perches
@ 2020-11-16  9:17   ` Pablo Neira Ayuso
  0 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2020-11-16  9:17 UTC (permalink / raw)
  To: Joe Perches
  Cc: Lukas Bulwahn, Jozsef Kadlecsik, Florian Westphal,
	netfilter-devel, coreteam, Ralf Ramsauer, Pia Eichinger,
	kernel-janitors, linux-kernel

Hi Lukas,

On Sun, Nov 15, 2020 at 07:58:33PM -0800, Joe Perches wrote:
> On Mon, 2020-11-09 at 10:19 +0100, Lukas Bulwahn wrote:
> > The two file patterns in the NETFILTER section:
> > 
> >   F:      include/linux/netfilter*
> >   F:      include/uapi/linux/netfilter*
> > 
> > intended to match the directories:
> > 
> >   ./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}
> > 
> > A quick check with ./scripts/get_maintainer.pl --letters -f will show that
> > they are not matched, though, because this pattern only matches files, but
> > not directories.
> > 
> > Rectify the patterns to match the intended directories.
> []
> diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -12139,10 +12139,10 @@ W:	http://www.nftables.org/
> >  Q:	http://patchwork.ozlabs.org/project/netfilter-devel/list/
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git
> > -F:	include/linux/netfilter*
> > +F:	include/linux/netfilter*/
> >  F:	include/linux/netfilter/
> 
> This line could be deleted or perhaps moved up one line above
> 
> F:	include/linux/netfilter/
> F:	include/linux/netfilter*/
> 
> (as the second line already matches the first line's files too)
> 
> >  F:	include/net/netfilter/
> > -F:	include/uapi/linux/netfilter*
> > +F:	include/uapi/linux/netfilter*/
> >  F:	include/uapi/linux/netfilter/
> 
> same here.
> 
> >  F:	net/*/netfilter.c
> >  F:	net/*/netfilter/

Please, send a v2 to address this feedback. Thank you.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-11-16 10:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-09  9:19 [PATCH] MAINTAINERS: rectify file patterns for NETFILTER Lukas Bulwahn
2020-11-15 11:19 ` Pablo Neira Ayuso
2020-11-16  3:58 ` Joe Perches
2020-11-16  9:17   ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox