netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Joe Perches <joe@perches.com>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	Florian Westphal <fw@strlen.de>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	Ralf Ramsauer <ralf.ramsauer@oth-regensburg.de>,
	Pia Eichinger <pia.eichinger@st.oth-regensburg.de>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: rectify file patterns for NETFILTER
Date: Mon, 16 Nov 2020 10:17:36 +0100	[thread overview]
Message-ID: <20201116091736.GA32490@salvia> (raw)
In-Reply-To: <d03c87f9fcc4bb68c148cfad12cafef5f2385eef.camel@perches.com>

Hi Lukas,

On Sun, Nov 15, 2020 at 07:58:33PM -0800, Joe Perches wrote:
> On Mon, 2020-11-09 at 10:19 +0100, Lukas Bulwahn wrote:
> > The two file patterns in the NETFILTER section:
> > 
> >   F:      include/linux/netfilter*
> >   F:      include/uapi/linux/netfilter*
> > 
> > intended to match the directories:
> > 
> >   ./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}
> > 
> > A quick check with ./scripts/get_maintainer.pl --letters -f will show that
> > they are not matched, though, because this pattern only matches files, but
> > not directories.
> > 
> > Rectify the patterns to match the intended directories.
> []
> diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -12139,10 +12139,10 @@ W:	http://www.nftables.org/
> >  Q:	http://patchwork.ozlabs.org/project/netfilter-devel/list/
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git
> > -F:	include/linux/netfilter*
> > +F:	include/linux/netfilter*/
> >  F:	include/linux/netfilter/
> 
> This line could be deleted or perhaps moved up one line above
> 
> F:	include/linux/netfilter/
> F:	include/linux/netfilter*/
> 
> (as the second line already matches the first line's files too)
> 
> >  F:	include/net/netfilter/
> > -F:	include/uapi/linux/netfilter*
> > +F:	include/uapi/linux/netfilter*/
> >  F:	include/uapi/linux/netfilter/
> 
> same here.
> 
> >  F:	net/*/netfilter.c
> >  F:	net/*/netfilter/

Please, send a v2 to address this feedback. Thank you.

      reply	other threads:[~2020-11-16 10:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09  9:19 Lukas Bulwahn
2020-11-15 11:19 ` Pablo Neira Ayuso
2020-11-16  3:58 ` Joe Perches
2020-11-16  9:17   ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201116091736.GA32490@salvia \
    --to=pablo@netfilter.org \
    --cc=coreteam@netfilter.org \
    --cc=fw@strlen.de \
    --cc=joe@perches.com \
    --cc=kadlec@netfilter.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pia.eichinger@st.oth-regensburg.de \
    --cc=ralf.ramsauer@oth-regensburg.de \
    --subject='Re: [PATCH] MAINTAINERS: rectify file patterns for NETFILTER' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox