From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED76FC433E0 for ; Thu, 21 Jan 2021 14:45:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6FBF22248 for ; Thu, 21 Jan 2021 14:45:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730506AbhAUOpS (ORCPT ); Thu, 21 Jan 2021 09:45:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731676AbhAUOpI (ORCPT ); Thu, 21 Jan 2021 09:45:08 -0500 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C771C0613ED for ; Thu, 21 Jan 2021 06:44:16 -0800 (PST) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94) (envelope-from ) id 1l2bC2-00035P-CK; Thu, 21 Jan 2021 15:44:14 +0100 Date: Thu, 21 Jan 2021 15:44:14 +0100 From: Phil Sutter To: Florian Westphal Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH 2/4] json: limit: set default burst to 5 Message-ID: <20210121144414.GQ3158@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Florian Westphal , netfilter-devel@vger.kernel.org References: <20210121135510.14941-1-fw@strlen.de> <20210121135510.14941-3-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121135510.14941-3-fw@strlen.de> Sender: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi! On Thu, Jan 21, 2021 at 02:55:08PM +0100, Florian Westphal wrote: > The tests fail because json printing omits a burst of 5 and > the parser treats that as 'burst 0'. While this patch is correct in that it aligns json and bison parser behaviours, I think omitting burst value in JSON output is a bug by itself: We don't care about output length and users are supposed to parse (and thus filter) the information anyway, so there's no gain from omitting such info. I'll address this in a separate patch, though. Thanks, Phil