From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Subject: [PATCH nft v2 0/3] fix icmpv6 id dependeny handling
Date: Tue, 15 Jun 2021 18:01:48 +0200 [thread overview]
Message-ID: <20210615160151.10594-1-fw@strlen.de> (raw)
v2: in patch 1, make sure set has elements and is anonymous.
Pablo reported following bug:
input: icmpv6 id 1
output: icmpv6 type { echo-request, echo-reply } icmpv6 parameter-problem 65536/16
First patch fixes delinearization to handle this correctly.
Second patch fixes a bug related to dependency removal.
Third patch adds test cases for this bug.
src/netlink_delinearize.c | 68 ++++++++++++++++++++++++++++++++++++--
src/payload.c | 61 ++++++++++++++++++++--------------
tests/py/ip/icmp.t | 1
tests/py/ip/icmp.t.json | 28 +++++++++++++++
tests/py/ip/icmp.t.payload.ip | 9 +++++
tests/py/ip6/icmpv6.t | 3 +
tests/py/ip6/icmpv6.t.json | 61 ++++++++++++++++++++++++++++++++++
tests/py/ip6/icmpv6.t.payload.ip6 | 21 +++++++++++
8 files changed, 225 insertions(+), 27 deletions(-)
next reply other threads:[~2021-06-15 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 16:01 Florian Westphal [this message]
2021-06-15 16:01 ` [PATCH nft v2 1/3] netlink_delinearize: add missing icmp id/sequence support Florian Westphal
2021-06-30 15:13 ` Phil Sutter
2021-06-30 15:34 ` Florian Westphal
2021-06-30 15:58 ` Florian Westphal
2021-06-30 17:12 ` Phil Sutter
2021-06-15 16:01 ` [PATCH nft v2 2/3] payload: do not remove icmp echo dependency Florian Westphal
2021-06-15 16:01 ` [PATCH nft v2 3/3] tests: add a icmp-reply only and icmpv6 id test cases Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615160151.10594-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).