From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 939F1C11F65 for ; Wed, 30 Jun 2021 09:49:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EA5561D0F for ; Wed, 30 Jun 2021 09:49:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233839AbhF3JwZ (ORCPT ); Wed, 30 Jun 2021 05:52:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233541AbhF3JwY (ORCPT ); Wed, 30 Jun 2021 05:52:24 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FBB4C061756; Wed, 30 Jun 2021 02:49:56 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1lyWqr-0008HK-CP; Wed, 30 Jun 2021 11:49:49 +0200 Date: Wed, 30 Jun 2021 11:49:49 +0200 From: Florian Westphal To: Vasily Averin Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Taehee Yoo , Julian Anastasov , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH NETFILTER] netfilter: nfnetlink: suspicious RCU usage in ctnetlink_dump_helpinfo Message-ID: <20210630094949.GA18022@breakpoint.cc> References: <65205a04-f1a3-9901-f6b7-eab8f482f37f@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65205a04-f1a3-9901-f6b7-eab8f482f37f@virtuozzo.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Vasily Averin wrote: > Two patches listed below removed ctnetlink_dump_helpinfo call from under > rcu_read_lock. Now its rcu_dereference generates following warning: > ============================= > WARNING: suspicious RCU usage > 5.13.0+ #5 Not tainted > ----------------------------- > net/netfilter/nf_conntrack_netlink.c:221 suspicious rcu_dereference_check() usage! Reviewed-by: Florian Westphal