From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH libnetfilter_queue v4 4/4] build: doc: split off shell script from within doxygen/Makefile.am
Date: Wed, 25 Aug 2021 08:08:38 +0200 [thread overview]
Message-ID: <20210825060838.GA818@salvia> (raw)
In-Reply-To: <YSXDyR2RIKf675l6@slk1.local.net>
On Wed, Aug 25, 2021 at 02:15:05PM +1000, Duncan Roe wrote:
> On Tue, Aug 24, 2021 at 12:30:52PM +0200, Pablo Neira Ayuso wrote:
> > On Sun, Aug 22, 2021 at 02:14:42PM +1000, Duncan Roe wrote:
> > > This time, Makefile obeys the script via its absolute source pathname rather
> > > than trying to force a copy into the build dir as we did previously.
> >
> > Could you make this in first place? As coming 1/x coming in this
> > series.
> >
> > Thanks.
>
> Time to wrap up the whole lot in a single patch.
>
> v5 was going to remove the make distcheck cruft in doxygen/Makefile.am, which is
> adjacent to the now-removed embedded script. So now there is juat 1 big block of
> red.
>
> I reverted some non-essential changes in configure.ac to reduce the diff.
>
> The new patch will be titled "Fix man pages".
At least two patches would be the best way to go for traceability:
#1 Move code to script.
#2 Your updates
The problem with code updates and moving code is that the diff patch
format is not very good at catching those together, since it makes it
look like code deleted plus new code.
Thanks!
next prev parent reply other threads:[~2021-08-25 6:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 4:14 [PATCH libnetfilter_queue v4 1/4] build: doc: Fix NAME entry in man pages Duncan Roe
2021-08-22 4:14 ` [PATCH libnetfilter_queue v4 2/4] build: doc: can choose what to build and install Duncan Roe
2021-08-24 10:30 ` Pablo Neira Ayuso
2021-08-25 1:21 ` Duncan Roe
2021-08-22 4:14 ` [PATCH libnetfilter_queue v4 3/4] build: doc: VPATH builds work again Duncan Roe
2021-08-24 10:28 ` Pablo Neira Ayuso
2021-08-25 1:57 ` Duncan Roe
2021-08-25 2:20 ` Duncan Roe
2021-08-25 6:10 ` Pablo Neira Ayuso
2021-08-22 4:14 ` [PATCH libnetfilter_queue v4 4/4] build: doc: split off shell script from within doxygen/Makefile.am Duncan Roe
2021-08-24 10:30 ` Pablo Neira Ayuso
2021-08-25 4:15 ` Duncan Roe
2021-08-25 6:08 ` Pablo Neira Ayuso [this message]
2021-08-25 7:36 ` Duncan Roe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825060838.GA818@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).