From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH nf 0/2] netfilter: nf_nat_masquerade: don't block rtnl lock
Date: Wed, 15 Sep 2021 16:46:37 +0200 [thread overview]
Message-ID: <20210915144639.25024-1-fw@strlen.de> (raw)
nf_nat_masquerade registers conntrack notifiers to early-expire
conntracks that have been using the downed device/removed address.
With large number of disappearing devices (ppp), iterating the table
for every notification blocks the rtnl lock for multiple seconds.
This change unconditionally defers the walk to the system work queue
so that rtnl lock is not blocked longer than needed.
This is not a regression, the notifier and cleanup walk have existed
since the functionality was added more than 20 years ago.
Florian Westphal (2):
netfilter: nf_nat_masquerade: make async masq_inet6_event handling
generic
netfilter: nf_nat_masquerade: defer conntrack walk to work queue
net/netfilter/nf_nat_masquerade.c | 168 +++++++++++++++++-------------
1 file changed, 97 insertions(+), 71 deletions(-)
--
2.32.0
next reply other threads:[~2021-09-15 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 14:46 Florian Westphal [this message]
2021-09-15 14:46 ` [PATCH nf 1/2] netfilter: nf_nat_masquerade: make async masq_inet6_event handling generic Florian Westphal
2021-09-15 14:46 ` [PATCH nf 2/2] netfilter: nf_nat_masquerade: defer conntrack walk to work queue Florian Westphal
2021-09-21 1:48 ` [PATCH nf 0/2] netfilter: nf_nat_masquerade: don't block rtnl lock Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915144639.25024-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).