From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B418EC6FA89 for ; Thu, 8 Sep 2022 15:56:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231467AbiIHP4N (ORCPT ); Thu, 8 Sep 2022 11:56:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231318AbiIHP4K (ORCPT ); Thu, 8 Sep 2022 11:56:10 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EE04B0895 for ; Thu, 8 Sep 2022 08:56:07 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1oWJsr-0005vt-KV; Thu, 08 Sep 2022 17:56:05 +0200 Date: Thu, 8 Sep 2022 17:56:05 +0200 From: Florian Westphal To: Phil Sutter , Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [PATCH iptables-nft 0/3] nft: prefer meta pkttype to libxt_pkttype Message-ID: <20220908155605.GA16543@breakpoint.cc> References: <20220908151242.26838-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > On Thu, Sep 08, 2022 at 05:12:39PM +0200, Florian Westphal wrote: > > low hanging fruit: use native meta+cmp instead of libxt_pkttype. > > First patch adds dissection, second patch switches to native expression. > > > > Last patch adds support for 'otherhost' mnemonic, useless for iptables > > but useful for ebtables. > > Reviewed-by: Phil Sutter Thanks for the quick review, applied.