From: Florian Westphal <fw@strlen.de>
To: Jeremy Sowden <jeremy@azazel.net>
Cc: Florian Westphal <fw@strlen.de>,
Netfilter Devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft 2/2] segtree: fix decomposition of unclosed intervals containing address prefixes
Date: Wed, 21 Sep 2022 22:26:59 +0200 [thread overview]
Message-ID: <20220921202659.GA30050@breakpoint.cc> (raw)
In-Reply-To: <YytqB90MypDn7gHr@azazel.net>
Jeremy Sowden <jeremy@azazel.net> wrote:
> > __interceptor_malloc libsanitizer/asan/asan_malloc_linux.cpp:145
> > xmalloc src/utils.c:36
> > xzalloc src/utils.c:75
> > expr_alloc src/expression.c:46
> > constant_expr_alloc src/expression.c:420
> > interval_map_decompose src/segtree.c:619
>
> I did try running the new shell test under valgrind: lots of noise, not
> a lot of signal. :)
Yes. You can use -fsanitize=leak as alternative, that has a much better
signal/noise ratio.
> > Before, 'i' was assigned to the compund expr, but thats no longer the
> > case.
>
> > Does this look good to you?
>
> Yes, LTGM.
Applied, thanks!
next prev parent reply other threads:[~2022-09-21 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 17:22 [PATCH nft 0/2] Fix listing of sets containing unclosed address prefix intervals Jeremy Sowden
2022-09-18 17:22 ` [PATCH nft 1/2] segtree: refactor decomposition of closed intervals Jeremy Sowden
2022-09-18 17:22 ` [PATCH nft 2/2] segtree: fix decomposition of unclosed intervals containing address prefixes Jeremy Sowden
2022-09-21 11:48 ` Florian Westphal
2022-09-21 19:46 ` Jeremy Sowden
2022-09-21 20:26 ` Florian Westphal [this message]
2022-09-18 21:02 ` [PATCH nft 0/2] Fix listing of sets containing unclosed address prefix intervals Jeremy Sowden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921202659.GA30050@breakpoint.cc \
--to=fw@strlen.de \
--cc=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).