From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E97C43603 for ; Fri, 20 Dec 2019 03:53:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A634124676 for ; Fri, 20 Dec 2019 03:53:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727125AbfLTDxq (ORCPT ); Thu, 19 Dec 2019 22:53:46 -0500 Received: from m9784.mail.qiye.163.com ([220.181.97.84]:44375 "EHLO m9784.mail.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727063AbfLTDxq (ORCPT ); Thu, 19 Dec 2019 22:53:46 -0500 Received: from [192.168.188.14] (unknown [120.132.1.226]) by m9784.mail.qiye.163.com (Hmail) with ESMTPA id 42CF14191F; Fri, 20 Dec 2019 11:53:39 +0800 (CST) Subject: Re: [PATCH nf v2 1/3] netfilter: nf_flow_table_offload: fix dst_neigh lookup To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org References: <1576572767-19779-1-git-send-email-wenxu@ucloud.cn> <1576572767-19779-2-git-send-email-wenxu@ucloud.cn> <20191219221816.rywke7de6izqrere@salvia> From: wenxu Message-ID: <25e03002-ba64-45aa-c94d-2588706ba6d8@ucloud.cn> Date: Fri, 20 Dec 2019 11:53:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191219221816.rywke7de6izqrere@salvia> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Content-Language: en-US X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZVkpVSENNS0tLSk5NT0tJTkJZV1koWU FJQjdXWS1ZQUlXWQkOFx4IWUFZNTQpNjo3JCkuNz5ZBg++ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6K1E6Hww*SjgrIUw1DxQvME0X DkowCgxVSlVKTkxNQ0pPS0pCQ05CVTMWGhIXVQweFQMOOw4YFxQOH1UYFUVZV1kSC1lBWUpJS1VK SElVSlVJSU1ZV1kIAVlBSU9JTDcG X-HM-Tid: 0a6f217084dc2086kuqy42cf14191f Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Maybe the patch your suggestion is not correct? On 12/20/2019 6:18 AM, Pablo Neira Ayuso wrote: > diff --git a/net/netfilter/nf_flow_table_offload.c b/net/netfilter/nf_flow_table_offload.c > index 506aaaf8151d..8680fc56cd7c 100644 > --- a/net/netfilter/nf_flow_table_offload.c > +++ b/net/netfilter/nf_flow_table_offload.c > @@ -156,14 +156,14 @@ static int flow_offload_eth_dst(struct net *net, > enum flow_offload_tuple_dir dir, > struct nf_flow_rule *flow_rule) > { > - const struct flow_offload_tuple *tuple = &flow->tuplehash[dir].tuple; > + const struct flow_offload_tuple *tuple = &flow->tuplehash[!dir].tuple; > struct flow_action_entry *entry0 = flow_action_entry_next(flow_rule); > struct flow_action_entry *entry1 = flow_action_entry_next(flow_rule); > struct neighbour *n; > u32 mask, val; > u16 val16; > > - n = dst_neigh_lookup(tuple->dst_cache, &tuple->dst_v4); > + n = dst_neigh_lookup(tuple->dst_cache, &tuple->src_v4);                 The dst_cache should be flow->tuplehash[dir].tuple.dst_cache  but not peer dir's; > if (!n) > return -ENOENT; > >