From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3117C6FA82 for ; Mon, 12 Sep 2022 17:22:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229892AbiILRW5 (ORCPT ); Mon, 12 Sep 2022 13:22:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbiILRW5 (ORCPT ); Mon, 12 Sep 2022 13:22:57 -0400 Received: from smtp-8fa8.mail.infomaniak.ch (smtp-8fa8.mail.infomaniak.ch [83.166.143.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF8DC6418 for ; Mon, 12 Sep 2022 10:22:55 -0700 (PDT) Received: from smtp-2-0000.mail.infomaniak.ch (unknown [10.5.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4MRD262fsJzMrnVZ; Mon, 12 Sep 2022 19:22:54 +0200 (CEST) Received: from ns3096276.ip-94-23-54.eu (unknown [23.97.221.149]) by smtp-2-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4MRD255zdczMpnPm; Mon, 12 Sep 2022 19:22:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1663003374; bh=0WzaSef2XgErcG0CnIsn/ZKpCVJ/BEdcfIKpEeL4zW4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Z1BwLnwQSqB8HQkTzTDQAefRGgQc9xkDGFpplE7cqpVSLYZjJkEWh4o3NyD6OkqNh O3uMggZdUYjMomxyq0NdwQ4E6/AXwZ3bLf6QXmAp7CVkLVrquVdeKzItvS56CLB5OS QpP5f814OpMSqmTjR62Y/esDR6xFS+SqAMXVTvt4= Message-ID: <36de86ad-460c-81d0-b5bd-4d54bd05d201@digikod.net> Date: Mon, 12 Sep 2022 19:22:53 +0200 MIME-Version: 1.0 User-Agent: Subject: Re: [PATCH v7 16/18] seltests/landlock: add invalid input data test Content-Language: en-US To: "Konstantin Meskhidze (A)" Cc: willemdebruijn.kernel@gmail.com, gnoack3000@gmail.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, anton.sirazetdinov@huawei.com References: <20220829170401.834298-1-konstantin.meskhidze@huawei.com> <20220829170401.834298-17-konstantin.meskhidze@huawei.com> <47ddb2ea-3bc7-533a-9b0d-2b2d3950644c@huawei.com> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= In-Reply-To: <47ddb2ea-3bc7-533a-9b0d-2b2d3950644c@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On 10/09/2022 22:51, Konstantin Meskhidze (A) wrote: > > > 9/6/2022 11:09 AM, Mickaël Salaün пишет: >> >> On 29/08/2022 19:03, Konstantin Meskhidze wrote: >>> This patch adds rules with invalid user space supplied data: >>> - out of range ruleset attribute; >>> - unhandled allowed access; >>> - zero port value; >>> - zero access value; >>> >>> Signed-off-by: Konstantin Meskhidze >>> --- >>> >>> Changes since v6: >>> * Adds invalid ruleset attribute test. >>> >>> Changes since v5: >>> * Formats code with clang-format-14. >>> >>> Changes since v4: >>> * Refactors code with self->port variable. >>> >>> Changes since v3: >>> * Adds inval test. >>> >>> --- >>> tools/testing/selftests/landlock/net_test.c | 66 ++++++++++++++++++++- >>> 1 file changed, 65 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/landlock/net_test.c b/tools/testing/selftests/landlock/net_test.c >>> index a93224d1521b..067ba45f58a5 100644 >>> --- a/tools/testing/selftests/landlock/net_test.c >>> +++ b/tools/testing/selftests/landlock/net_test.c >>> @@ -26,9 +26,12 @@ >>> >>> #define IP_ADDRESS "127.0.0.1" >>> >>> -/* Number pending connections queue to be hold */ >>> +/* Number pending connections queue to be hold. */ >> >> Patch of a previous patch? >> >> >>> #define BACKLOG 10 >>> >>> +/* Invalid attribute, out of landlock network access range. */ >>> +#define LANDLOCK_INVAL_ATTR 7 >>> + >>> FIXTURE(socket) >>> { >>> uint port[MAX_SOCKET_NUM]; >>> @@ -719,4 +722,65 @@ TEST_F(socket, ruleset_expanding) >>> /* Closes socket 1. */ >>> ASSERT_EQ(0, close(sockfd_1)); >>> } >>> + >>> +TEST_F(socket, inval) >>> +{ >>> + struct landlock_ruleset_attr ruleset_attr = { >>> + .handled_access_net = LANDLOCK_ACCESS_NET_BIND_TCP >>> + }; >>> + struct landlock_ruleset_attr ruleset_attr_inval = { >>> + .handled_access_net = LANDLOCK_INVAL_ATTR >> >> Please add a test similar to TEST_F_FORK(layout1, >> file_and_dir_access_rights) instead of explicitly defining and only >> testing LANDLOCK_INVAL_ATTR. >> > Do you want fs test to be in this commit or maybe its better to add > it into "[PATCH v7 01/18] landlock: rename access mask" one. You can squash all the new tests patches (except the "move helper function").