Re: [PATCH] netfilter: xtables: add cluster match

From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: xtables: add cluster match
Date: Tue, 24 Feb 2009 14:46:51 +0100	[thread overview]
Message-ID: <49A3FA4B.5000107@trash.net> (raw)
In-Reply-To: <20090223101354.7104.45999.stgit@Decadence>

Pablo Neira Ayuso wrote:
> +enum xt_cluster_flags {
> +	XT_CLUSTER_F_INV	= (1 << 0)
> +};
> +
> +struct xt_cluster_match_info {
> +	u_int32_t		total_nodes;
> +	u_int32_t		node_mask;
> +	u_int32_t		hash_seed;
> +	u_int32_t		flags;
> +};

This doesn't seem like such a hot idea. I haven't seen the new
userspace patch, but assuming you're interested in the flags and
not ignoring them in userspace, the user has to specify the hash
seed for rule deletions.

You also have to chose the same seed for all nodes in a cluster.
This seems needlessly complicated, I'd suggest to simply use zero.