From: Edward Cree <ecree@solarflare.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<netfilter-devel@vger.kernel.org>, <jiri@resnulli.us>,
<kuba@kernel.org>
Subject: Re: [PATCH net-next v2] net: flow_offload: simplify hw stats check handling
Date: Wed, 20 May 2020 16:18:37 +0100 [thread overview]
Message-ID: <981c02e9-6152-feed-2607-9607e58b760c@solarflare.com> (raw)
In-Reply-To: <20200520143330.GA23050@salvia>
On 20/05/2020 15:33, Pablo Neira Ayuso wrote:
> #1 Drivers calling flow_action_hw_stats_check() fall within the
> second branch (check_allow_bit is set on).
>
> } else if (check_allow_bit && <------ HERE
>
> These drivers are not honoring the _DONT_CARE bit,
> __flow_action_hw_stats_check() with check_allow_bit set on does not
> honor the _DONT_CARE bit.
I don't understand. There isn't a _DONT_CARE bit; _DONT_CARE isa
bitmask of *all* the bits: BIT(FLOW_ACTION_HW_STATS_NUM_BITS) - 1.
So if allow_bit < FLOW_ACTION_HW_STATS_NUM_BITS, then
BIT(allow_bit) & FLOW_ACTION_HW_STATS_DONT_CARE is nonzero, and
thus the function returns true.
> #2 Your patch needs to update Netfilter to set hw_stats to
> FLOW_ACTION_HW_STATS_DONT_CARE explicitly.
Ahh, naïvely I had assumed that you would have done that in the
patch that added _DONT_CARE; I should have checked that. Will
fix that for the next version.
Thank you for being specific.
And you'll be pleased to know that I've managed to bodge a working
nft binary onto my test system, so hopefully I'll be able to test
with netfilter offload. Am I right in thinking that an ingress
chain on the netdev table is the thing I want?
-ed
next prev parent reply other threads:[~2020-05-20 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 17:02 [PATCH net-next v2] net: flow_offload: simplify hw stats check handling Edward Cree
2020-05-19 17:19 ` Pablo Neira Ayuso
2020-05-19 17:23 ` Edward Cree
2020-05-19 17:35 ` Pablo Neira Ayuso
2020-05-19 18:26 ` Edward Cree
2020-05-20 14:33 ` Pablo Neira Ayuso
2020-05-20 15:18 ` Edward Cree [this message]
2020-05-19 19:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=981c02e9-6152-feed-2607-9607e58b760c@solarflare.com \
--to=ecree@solarflare.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).