From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F4DFC4363D for ; Tue, 6 Oct 2020 12:48:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C39E3206F7 for ; Tue, 6 Oct 2020 12:48:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UalqqU/Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726608AbgJFMsg (ORCPT ); Tue, 6 Oct 2020 08:48:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726459AbgJFMsg (ORCPT ); Tue, 6 Oct 2020 08:48:36 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C29C9C0613D2 for ; Tue, 6 Oct 2020 05:48:35 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id gm14so1508146pjb.2 for ; Tue, 06 Oct 2020 05:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sQ1ZRFw1JVrb5mdbUnbQ1Xk6xyYpoV5fP4T8uAyz2hw=; b=UalqqU/Z4KF3vbZHbjIAfQig+pegJIOxqYiWL3gE2jPszs3jZTgNm72XNKp1ktSBl0 P0DrPhYxjP92TkK+Tfx4UYVBfVvTOTHUbzfIpsmDtsGUQgPnAwTNyL0jhjDrXIjKmjwS 25f+VrZAN7jHTdovX7Sm84YxtK/nCdB3vj14lNHA3QFSdyYd5XYXrRc9GhYmJOXaWCDW 0l+as7z3dms6Lv2sT1SCz0TJqDJUfL8YrQBsu3pBXkmqTsom0EVy23LLx/xm+YEsDpOl Vx0HH0Dt104si2kx4f5kc+7p+JWCuVudnHX3f+XCG7amVwTzGlBGKAsNSQYgPCdevAq2 Ve9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sQ1ZRFw1JVrb5mdbUnbQ1Xk6xyYpoV5fP4T8uAyz2hw=; b=aZjMyogDoYNkzsq7Us0ktvmrq3mFilYGK/DUMQVZMw9lbwI+kiyy0RWwY/L9GdTUUr usKLJqd1sx/BXClMz2nsOp50MUH/3dzyG3JI2S42/3UrXkAvTLycY5KVc/2P1cFBLtoY aoiXttlH60V/n4U+hJ0I4x5kkyIXCBfGTQsKmQzr1BOsPGOsb22XsCqdIFAVsl5x5Y1w xq8KCwVV/sio6Mp8H1/et8LwVE1gix41CO97XlJuRWtRk/1ejaSaPsaMGCXRICOWVYuf 5eaiAyVU8bXPwrCR70oyBjCbTCSTow1MxDVt9Dup0vSFf9J+BmAJI2V5J+Rb76zEg08f zRNg== X-Gm-Message-State: AOAM531V43AzW2PfPzl8O6VHKaunUm3IwOeZqduK+pARQBsiA2gjmF/D 5C4+LCifEF2jY5Ay/25/WuhoLdiiGTjn+xnQ7EdKtg== X-Google-Smtp-Source: ABdhPJxuTIkgeLojC1+VzV9TJd68luIqrRj+YDKPNYmX1CJV4VYlVmG35Q89ehXC3dXM9OFSlZ37iW033GsrkAVyMuI= X-Received: by 2002:a17:90a:6043:: with SMTP id h3mr4137676pjm.41.1601988514966; Tue, 06 Oct 2020 05:48:34 -0700 (PDT) MIME-Version: 1.0 References: <0000000000004831d405b0fc41d2@google.com> <0b0de451147224657e5ac42d755c05447ee530b0.camel@suse.de> In-Reply-To: <0b0de451147224657e5ac42d755c05447ee530b0.camel@suse.de> From: Andrey Konovalov Date: Tue, 6 Oct 2020 14:48:23 +0200 Message-ID: Subject: Re: INFO: task hung in hub_port_init To: Oliver Neukum Cc: syzbot , coreteam@netfilter.org, "David S. Miller" , Greg Kroah-Hartman , gustavoars@kernel.org, ingrassia@epigenesys.com, Patrick McHardy , Jozsef Kadlecsik , LKML , linux-renesas-soc@vger.kernel.org, USB list , netdev , netfilter-devel@vger.kernel.org, niklas.soderlund+renesas@ragnatech.se, Pablo Neira Ayuso , sergei.shtylyov@cogentembedded.com, syzkaller-bugs Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Oct 6, 2020 at 10:56 AM Oliver Neukum wrote: > > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=152bb760500000 > > final oops: https://syzkaller.appspot.com/x/report.txt?x=172bb760500000 > > console output: https://syzkaller.appspot.com/x/log.txt?x=132bb760500000 > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > Reported-by: syzbot+74d6ef051d3d2eacf428@syzkaller.appspotmail.com > > Fixes: 6dcf45e51497 ("sh_eth: use correct name for ECMR_MPDE bit") > > > > INFO: task kworker/0:0:5 blocked for more than 143 seconds. > > Not tainted 5.9.0-rc7-syzkaller #0 > > "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > > task:kworker/0:0 state:D stack:27664 pid: 5 ppid: 2 flags:0x00004000 > > Workqueue: usb_hub_wq hub_event > > Call Trace: > > context_switch kernel/sched/core.c:3778 [inline] > > __schedule+0xec9/0x2280 kernel/sched/core.c:4527 > > schedule+0xd0/0x2a0 kernel/sched/core.c:4602 > > By this time urb_dequeue() has been killed and has returned. > > > usb_kill_urb.part.0+0x197/0x220 drivers/usb/core/urb.c:696 > > usb_kill_urb+0x7c/0x90 drivers/usb/core/urb.c:691 > > usb_start_wait_urb+0x24a/0x2b0 drivers/usb/core/message.c:64 > > usb_internal_control_msg drivers/usb/core/message.c:102 [inline] > > usb_control_msg+0x31c/0x4a0 drivers/usb/core/message.c:153 > > hub_port_init+0x11ae/0x2d80 drivers/usb/core/hub.c:4689 > > hub_port_connect drivers/usb/core/hub.c:5140 [inline] > > hub_port_connect_change drivers/usb/core/hub.c:5348 [inline] > > port_event drivers/usb/core/hub.c:5494 [inline] > > > > This looks like it should. > > Which HC driver are you using for these tests? Hi Oliver, This is the USB/IP one, based on what I see in the reproducer. Thanks! > It looks like > the HCD is not acting on urb_dequeue(), rather than a locking > issue.