From: Dongliang Mu <mudongliangabcd@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Richard Guy Briggs <rgb@redhat.com>,
Paul Moore <paul@paul-moore.com>,
syzbot <syzkaller@googlegroups.com>,
kernel test robot <lkp@intel.com>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] audit: fix memory leak in nf_tables_commit
Date: Wed, 14 Jul 2021 10:18:36 +0800 [thread overview]
Message-ID: <CAD-N9QWmNYPkim_KrnUfvNhErUZaJqwGH-_3QvivVEvg+KnHjA@mail.gmail.com> (raw)
In-Reply-To: <20210713153115.GC11179@breakpoint.cc>
On Tue, Jul 13, 2021 at 11:31 PM Florian Westphal <fw@strlen.de> wrote:
>
> Dongliang Mu <mudongliangabcd@gmail.com> wrote:
> > > > +static void nf_tables_commit_free(struct list_head *adl)
> > >
> > > nf_tables_commit_audit_free?
> >
> > What do you mean? Modify the name of newly added function to
> > nf_tables_commit_audit_free?
>
> Yes, this function is audit related, and it does the inverse
> of existing '...audit_alloc'.
Hi Florian,
I double-check the patch, and it seems there is no need to send a
followup patch (nf-next).
I will send a v3 patch with the new function name.
Best regards
Dongliang Mu
prev parent reply other threads:[~2021-07-14 2:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 13:03 [PATCH v2] audit: fix memory leak in nf_tables_commit Dongliang Mu
2021-07-13 13:20 ` Florian Westphal
2021-07-13 14:40 ` Dongliang Mu
2021-07-13 15:31 ` Florian Westphal
2021-07-14 2:18 ` Dongliang Mu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD-N9QWmNYPkim_KrnUfvNhErUZaJqwGH-_3QvivVEvg+KnHjA@mail.gmail.com \
--to=mudongliangabcd@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).