From: Paul Moore <paul@paul-moore.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: nhorman@tuxdriver.com, linux-api@vger.kernel.org,
containers@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
dhowells@redhat.com,
Linux-Audit Mailing List <linux-audit@redhat.com>,
netfilter-devel@vger.kernel.org, ebiederm@xmission.com,
simo@redhat.com, netdev@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Eric Paris <eparis@parisplace.org>,
mpatel@redhat.com, Serge Hallyn <serge@hallyn.com>,
aris@redhat.com
Subject: Re: [PATCH ghak90 V9 11/13] audit: contid check descendancy and nesting
Date: Fri, 21 Aug 2020 16:13:45 -0400 [thread overview]
Message-ID: <CAHC9VhQ3MVUY8Zs4GNXdaqhiPJBzHW_YcCe=DghAgo7g6yrNBw@mail.gmail.com> (raw)
In-Reply-To: <20200807171025.523i2sxfyfl7dfjy@madcap2.tricolour.ca>
On Fri, Aug 7, 2020 at 1:10 PM Richard Guy Briggs <rgb@redhat.com> wrote:
> On 2020-07-05 11:11, Paul Moore wrote:
> > On Sat, Jun 27, 2020 at 9:23 AM Richard Guy Briggs <rgb@redhat.com> wrote:
> > > Require the target task to be a descendant of the container
> > > orchestrator/engine.
If you want to get formal about this, you need to define "target" in
the sentence above. Target of what?
FWIW, I read the above to basically mean that a task can only set the
audit container ID of processes which are beneath it in the "process
tree" where the "process tree" is defined as the relationship between
a parent and children processes such that the children processes are
branches below the parent process.
I have no problem with that, with the understanding that nesting
complicates it somewhat. For example, this isn't true when one of the
children is a nested orchestrator, is it?
> > > You would only change the audit container ID from one set or inherited
> > > value to another if you were nesting containers.
I thought we decided we were going to allow an orchestrator to move a
process between audit container IDs, yes? no?
> > > If changing the contid, the container orchestrator/engine must be a
> > > descendant and not same orchestrator as the one that set it so it is not
> > > possible to change the contid of another orchestrator's container.
Try rephrasing the above please, it isn't clear to me what you are
trying to say.
> Are we able to agree on the premises above? Is anything asserted that
> should not be and is there anything missing?
See above.
If you want to go back to the definitions/assumptions stage, it
probably isn't worth worrying about the other comments until we get
the above sorted.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2020-08-21 20:14 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-27 13:20 [PATCH ghak90 V9 00/13] audit: implement container identifier Richard Guy Briggs
2020-06-27 13:20 ` [PATCH ghak90 V9 01/13] audit: collect audit task parameters Richard Guy Briggs
2020-07-05 15:09 ` Paul Moore
2020-07-07 2:50 ` Richard Guy Briggs
2020-07-08 1:42 ` Paul Moore
2020-07-13 20:29 ` Richard Guy Briggs
2020-07-14 0:44 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 02/13] audit: add container id Richard Guy Briggs
2020-07-04 13:29 ` Paul Moore
2020-07-04 13:30 ` Paul Moore
2020-07-05 15:09 ` Paul Moore
2020-07-29 20:05 ` Richard Guy Briggs
2020-08-21 19:36 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 03/13] audit: read container ID of a process Richard Guy Briggs
2020-06-27 13:20 ` [PATCH ghak90 V9 04/13] audit: log drop of contid on exit of last task Richard Guy Briggs
2020-07-05 15:10 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 05/13] audit: log container info of syscalls Richard Guy Briggs
2020-07-05 15:10 ` Paul Moore
2020-07-29 19:40 ` Richard Guy Briggs
2020-08-21 19:15 ` Paul Moore
2020-10-02 19:52 ` Richard Guy Briggs
2020-10-21 16:39 ` Richard Guy Briggs
2020-10-21 16:49 ` Steve Grubb
2020-10-21 17:53 ` Richard Guy Briggs
2020-10-23 1:21 ` Paul Moore
2020-10-23 20:40 ` Richard Guy Briggs
2020-10-28 1:35 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 06/13] audit: add contid support for signalling the audit daemon Richard Guy Briggs
2020-07-05 15:10 ` Paul Moore
2020-07-29 19:00 ` Richard Guy Briggs
2020-08-21 18:48 ` Paul Moore
2020-10-02 19:25 ` Richard Guy Briggs
2020-06-27 13:20 ` [PATCH ghak90 V9 07/13] audit: add support for non-syscall auxiliary records Richard Guy Briggs
2020-07-05 15:11 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 08/13] audit: add containerid support for user records Richard Guy Briggs
2020-07-05 15:11 ` Paul Moore
2020-07-18 0:43 ` Richard Guy Briggs
2020-08-21 18:34 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 09/13] audit: add containerid filtering Richard Guy Briggs
2020-06-27 13:20 ` [PATCH ghak90 V9 10/13] audit: add support for containerid to network namespaces Richard Guy Briggs
2020-07-05 15:11 ` Paul Moore
2020-07-21 22:05 ` Richard Guy Briggs
2020-06-27 13:20 ` [PATCH ghak90 V9 11/13] audit: contid check descendancy and nesting Richard Guy Briggs
2020-07-05 15:11 ` Paul Moore
2020-08-07 17:10 ` Richard Guy Briggs
2020-08-21 20:13 ` Paul Moore [this message]
2020-10-06 20:03 ` Richard Guy Briggs
2020-06-27 13:20 ` [PATCH ghak90 V9 12/13] audit: track container nesting Richard Guy Briggs
2020-07-05 15:11 ` Paul Moore
2020-06-27 13:20 ` [PATCH ghak90 V9 13/13] audit: add capcontid to set contid outside init_user_ns Richard Guy Briggs
2020-07-05 15:11 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhQ3MVUY8Zs4GNXdaqhiPJBzHW_YcCe=DghAgo7g6yrNBw@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=aris@redhat.com \
--cc=containers@lists.linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eparis@parisplace.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-audit@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatel@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=rgb@redhat.com \
--cc=serge@hallyn.com \
--cc=simo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).