From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00C55C3524D for ; Tue, 4 Feb 2020 15:52:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAC942084E for ; Tue, 4 Feb 2020 15:52:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore-com.20150623.gappssmtp.com header.i=@paul-moore-com.20150623.gappssmtp.com header.b="jV+b0Pt2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727355AbgBDPwv (ORCPT ); Tue, 4 Feb 2020 10:52:51 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:36199 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727336AbgBDPwv (ORCPT ); Tue, 4 Feb 2020 10:52:51 -0500 Received: by mail-ed1-f66.google.com with SMTP id j17so20272153edp.3 for ; Tue, 04 Feb 2020 07:52:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0d0fJd2kqJOBxIhDrO5YQ550FVzvPHsXp/LZedW7iYo=; b=jV+b0Pt2SFxKxAS8cj1UQHfhP4u6Is0Ked6engWmcGC4Vi3TiaYTuMDEDShbyo/W7Z 1G3Z0cM0PQWOg38Z+JVqucnhUkVnrOHTg50fin3WAGhZgHIYgSQ19+fPt7zs5oVqfJea pFWTF/n1Y213SSzHRtw5+jlUvJShRGJ7FhRpHhM1nAXcPW2m+/YHt61prqobroLuGOGk Y1CQM8QgSJwCyjxAesY/KCzkHfxFaZvogMV+xmE/W9owG68Y6pOv1plJSjhJiJzmsdiF xLMebzV4Z6XBRCCVQYgqj7kXbOFpljAZJuaOraWTomEviTzwCFj9906EhFb5Yal9kDuO Yt1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0d0fJd2kqJOBxIhDrO5YQ550FVzvPHsXp/LZedW7iYo=; b=DRdUo1e9TIjFyi2RieySwTIZfiM+D0bT6rq7iSzbIDSqWukAFwuekcLpMJKYJo2Te9 qcW054IVk5ZkDhbJZ0U4gsIP9EzdISEIiEc1hQiw1n3aohJ4wx2u8LoHjsg0vC1l+19H YjtMUXwzybL3pguxk0RWJ5smgNeILYYmXT0R7JxxbqYD+0JrcWp+Kk7mPmUZXCXbGrfh tkAsDWW0NheSr6cBb8WwgdUT+mhhJtljbvTCy0QirouMAYwrgJ72dDxoxe+jsdz8je6s j3ITLVQqeqYK0kthyXrvsJzPDAn83vh9HS6tHDtzufNQQEBh2qsLmtWHBWievph0nE/u +F0A== X-Gm-Message-State: APjAAAWaksm455dO24YDEhidQYvVSXJ02LSzaMxvXwOXuFYukJXMnDOh /kzTyB+K0NRk6XE1/uTVQ/mONWMvLvzo5gGHKEfv X-Google-Smtp-Source: APXvYqw+zYvw6F4Umt3lSDJsc2lvOiKELPOHsE6Als0Io7phWfq8MkukCyGdnY7at8Qo98R48gqGhqoNt5voV/XvnH4= X-Received: by 2002:a17:906:22cf:: with SMTP id q15mr26062018eja.77.1580831567900; Tue, 04 Feb 2020 07:52:47 -0800 (PST) MIME-Version: 1.0 References: <5238532.OiMyN8JqPO@x2> <20200204131944.esnzcqvnecfnqgbi@madcap2.tricolour.ca> <3665686.i1MIc9PeWa@x2> In-Reply-To: <3665686.i1MIc9PeWa@x2> From: Paul Moore Date: Tue, 4 Feb 2020 10:52:36 -0500 Message-ID: Subject: Re: [PATCH ghak90 V8 13/16] audit: track container nesting To: Steve Grubb Cc: Richard Guy Briggs , containers@lists.linux-foundation.org, linux-api@vger.kernel.org, Linux-Audit Mailing List , linux-fsdevel@vger.kernel.org, LKML , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, omosnace@redhat.com, dhowells@redhat.com, simo@redhat.com, Eric Paris , Serge Hallyn , ebiederm@xmission.com, nhorman@tuxdriver.com, Dan Walsh , mpatel@redhat.com Content-Type: text/plain; charset="UTF-8" Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Feb 4, 2020 at 10:47 AM Steve Grubb wrote: > On Tuesday, February 4, 2020 8:19:44 AM EST Richard Guy Briggs wrote: > > > The established pattern is that we print -1 when its unset and "?" when > > > its totalling missing. So, how could this be invalid? It should be set > > > or not. That is unless its totally missing just like when we do not run > > > with selinux enabled and a context just doesn't exist. > > > > Ok, so in this case it is clearly unset, so should be -1, which will be a > > 20-digit number when represented as an unsigned long long int. > > > > Thank you for that clarification Steve. > > It is literally a -1. ( 2 characters) Well, not as Richard has currently written the code, it is a "%llu". This was why I asked the question I did; if we want the "-1" here we probably want to special case that as I don't think we want to display audit container IDs as signed numbers in general. -- paul moore www.paul-moore.com