From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23238C2D0EC for ; Thu, 26 Mar 2020 18:34:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6A8C2070A for ; Thu, 26 Mar 2020 18:34:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TFeJEhdC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728148AbgCZSe2 (ORCPT ); Thu, 26 Mar 2020 14:34:28 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:44627 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727995AbgCZSe2 (ORCPT ); Thu, 26 Mar 2020 14:34:28 -0400 Received: by mail-lj1-f195.google.com with SMTP id p14so7486043lji.11; Thu, 26 Mar 2020 11:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qvltw6BbIljlptDziJDx+3Nqzbv74mwgS1caIyZyJQg=; b=TFeJEhdCEPi7VwXF/H8eJJt3cXZX7pONtl9zpMzXWNv/UoXloPbyCcjZhevebNEx0u 8IAdq09+VIvhFJLPr/VbUl7TIywXJwKwc348h7BToxqySyTM+CbE2/y887DSaVO/tQsJ sy5D2oy/Cxo44tOMRW3juh7lylW6byzBUXUGjMLkj1+TQHRnD259Sg2y4THzOz/G2Qj0 2E0v23scukAEDZJwGj/6QHZhHc6fptxvQ3EJNTOBf6ne3JSmwCQ8Fzz9erWwPxuJMfOF s2VP6CQWAPGVguewDsEExEBNm4TiQc0JdYeC/ENT/GH+dEJZU22FLQ3x6ujCvjW/ksdQ yCrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qvltw6BbIljlptDziJDx+3Nqzbv74mwgS1caIyZyJQg=; b=rH4Ky04MYUX5FliglOvnWB3bjW2bJhyJecyuG4HUWIhpERhxECp7kKQ0O6UcNEHD/I Wpdomc6ay8orjw04Mh22yCB4k5LnmZaaAZgRmbZwn+jErvjXkYBVjStnwq8yLONN/lnR pcCfBR1A6CRlySIImJM//QXBUUoZv/ygvTmIOUfJzq1QbEZaN5EZEZwi2cTRsmg9jBrS JsOlJGzmvE5zy04H+qpDGcr4VTSKxy5uqf1JLJw3mbtrNu0vYHwa84e8sT2XUNuldErg hO7G+k4MLnb2vHnj8anoEDDaPep6ejDtLIxv4OPSeniwN2y9S6+A3wihu3nJxWSSfy4T U+LQ== X-Gm-Message-State: AGi0PuaQCWSGk2dxXnGeoZajONFZmPX6owmR+0cdQ67xFwGoG1lLlZez Roezm2deweoq1adcJe2kRGZ9Q64L8GLW9Olla/w= X-Google-Smtp-Source: ADFU+vu+SpIkmy3ikTRV7PMLFD4FWNRZFGTNLY+5Hm98SXkmutWm7RkuB7yWfFAUpFErAW4lDXZJcG3cgntW02vEpGE= X-Received: by 2002:a2e:8084:: with SMTP id i4mr5982810ljg.185.1585247664310; Thu, 26 Mar 2020 11:34:24 -0700 (PDT) MIME-Version: 1.0 References: <20200326142803.239183-1-zenczykowski@gmail.com> <20200326113048.250e7098@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200326113048.250e7098@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: =?UTF-8?Q?Maciej_=C5=BBenczykowski?= Date: Thu, 26 Mar 2020 11:34:14 -0700 Message-ID: Subject: Re: [PATCH v2] iptables: open eBPF programs in read only mode To: Jakub Kicinski Cc: Pablo Neira Ayuso , Florian Westphal , Linux Network Development Mailing List , Netfilter Development Mailing List , Chenbo Feng , Alexei Starovoitov , Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org > FWIW the BPF subsystem is about to break uAPI backward-compat and > replace the defines with enums. See commit 1aae4bdd7879 ("bpf: Switch > BPF UAPI #define constants used from BPF program side to enums"). Shouldn't it do what is normally done in such a case? #define BPF_F_RDONLY BPF_F_RDONLY