From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vaishali Thakkar Subject: Re: [PATCH] netfilter: xtables: Add helper macro for xt_match boilerplate Date: Fri, 31 Jul 2015 07:33:20 +0530 Message-ID: References: <20150726115737.GA14070@vaishali-Ideapad-Z570> <20150730122433.GA5948@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Patrick McHardy , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org To: Pablo Neira Ayuso Return-path: In-Reply-To: <20150730122433.GA5948@salvia> Sender: linux-kernel-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Thu, Jul 30, 2015 at 5:54 PM, Pablo Neira Ayuso wrote: > On Sun, Jul 26, 2015 at 05:27:37PM +0530, Vaishali Thakkar wrote: >> For simple modules that contain a single xt_match without any >> additional setup code then ends up being a block of duplicated >> boilerplate. This patch adds a new macro, module_xt_match(), >> which replaces the module_init()/module_exit() registrations with >> template functions. > > I prefer not to use this macro, we may need to add something to the > module_init()/module_exit() path in the future to these netfilter > extensions and then we'll have to revert the follow up conversions > patches that you will likely send. Ok. This makes sense. I think in that case you can drop the patch. Thank You. > Thanks anyway. -- Vaishali