From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F88C76190 for ; Mon, 22 Jul 2019 10:17:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6709C218A0 for ; Mon, 22 Jul 2019 10:17:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729368AbfGVKRJ (ORCPT ); Mon, 22 Jul 2019 06:17:09 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:45490 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728569AbfGVKRJ (ORCPT ); Mon, 22 Jul 2019 06:17:09 -0400 Received: by mail-qk1-f195.google.com with SMTP id s22so28165276qkj.12; Mon, 22 Jul 2019 03:17:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7CJkKA7SZFRonSxwlZKyw8W6pgs5EdX5dwdC50uPvBs=; b=IfyEGn1teOvseGqamLGm6eYMrp4kEADYmxLmuf3lwn47e7irJLZzzSadD5rA/AIBI9 goH41xTw+8mHRl1BZvXsR//j0Bkx/qgpjDwxg+U0Sgv/xiZjg8KtvmyTZALR9IWcaIXV CkKHYuQh8zqpoaziifRWNQJj6IFlA4GCuNLjekCgFw/JORcJrYdvAW9z1V4W6KoM1wwm VULx2b8vVGz68sAMPswtsad+XUrTWq6NgpiZCM1ZVw4TMgy/CGbdJbHgWLP86SU1dGvd Z5pyX3CkxJbOlpaYN+NcMGuBrk11hsJl17wOl6wns3nwJxlMqgXlSlT1u12RZg1yhaEA FtQA== X-Gm-Message-State: APjAAAXq6SoJbRtNpNdtsju6Iqd40f0IQCjpznLrKw1xRcgd1JB/roKO 6vLan+lWSBG81Y9PJP7R6HGzDTE7JDS31A46Yqg= X-Google-Smtp-Source: APXvYqy7ISax661sJxUrp3WbLhv5BC0kus4uGgZKznelHiJHcAGScOZIvY+BAP14dw/qwJzgUC+dnqfk8j1fG+ylzm4= X-Received: by 2002:a37:4ac3:: with SMTP id x186mr44360140qka.138.1563790627957; Mon, 22 Jul 2019 03:17:07 -0700 (PDT) MIME-Version: 1.0 References: <20190628123819.2785504-1-arnd@arndb.de> <20190628123819.2785504-4-arnd@arndb.de> In-Reply-To: From: Arnd Bergmann Date: Mon, 22 Jul 2019 12:16:51 +0200 Message-ID: Subject: Re: [PATCH 4/4] ipvs: reduce kernel stack usage To: Julian Anastasov Cc: Kees Cook , Wensong Zhang , Simon Horman , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , James Smart , Dick Kennedy , "James E . J . Bottomley" , "Martin K . Petersen" , Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , James Morris , linux-scsi , Linux Kernel Mailing List , driverdevel , Networking , lvs-devel@vger.kernel.org, netfilter-devel , coreteam@netfilter.org, Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Sun, Jun 30, 2019 at 10:37 PM Julian Anastasov wrote: > On Fri, 28 Jun 2019, Arnd Bergmann wrote: > > struct ip_vs_conn *ctl_cp = cp->control; > > if (!ctl_cp) { > > - IP_VS_ERR_BUF("request control DEL for uncontrolled: " > > - "%s:%d to %s:%d\n", > > - IP_VS_DBG_ADDR(cp->af, &cp->caddr), > > - ntohs(cp->cport), > > - IP_VS_DBG_ADDR(cp->af, &cp->vaddr), > > - ntohs(cp->vport)); > > + pr_err("request control DEL for uncontrolled: " > > + "%pISp to %pISp\n", (replying a bit late) > ip_vs_dbg_addr() used compact form (%pI6c), so it would be > better to use %pISc and %pISpc everywhere in IPVS... done > Also, note that before now port was printed with %d and > ntohs() was used, now port should be in network order, so: > > - ntohs() should be removed done > - htons() should be added, if missing. At first look, this case > is not present in IPVS, we have only ntohs() usage I found one case in ip_vs_ftp_in() that needs it in order to subtract one: IP_VS_DBG(7, "protocol %s %pISpc %pISpc\n", ip_vs_proto_name(ipvsh->protocol), - IP_VS_DBG_SOCKADDR(cp->af, &to, ntohs(port)), + IP_VS_DBG_SOCKADDR(cp->af, &to, port), IP_VS_DBG_SOCKADDR(cp->af, &cp->vaddr, - ntohs(cp->vport)-1)); + htons(ntohs(cp->vport)-1))); Thanks for the review, I'll send a new patch after some more build testing on the new version. Arnd