Re: [PATCH] ipset: Add wildcard support to net,iface

[Kristian Evensen <kristian.evensen@gmail.com>]

Hi Jozsef,

On Wed, Oct 2, 2019 at 8:46 PM Kadlecsik József
<kadlec@blackhole.kfki.hu> wrote:
> Sorry for the long delay - I'm still pondering on the syntax.
>
> ip[6]tables uses the "+" notation for prefix matching. So in order to be
> compatible with it, it'd be better to use "ifac+" instead of
> "ifac prefix". The parsing/printing could be solved in the interface
> parser/printer functions internally. What do you think?

No worries about the delay :)

Before submitting the patch, I spent a lot of time thinking about the
syntax since, as you say, ip[6]tables uses "+" to indicate prefix
matching. The first version of the change checked for a "+"  at the
end of the interface name, instead of the wildcard flag. However, the
reason I went with the wildcard flag, was that I discovered that "+"
is a valid character in interface names on Linux. One thing we could
do, is to remove any trailing "+" if the wildcard flag is set.
However, I believe such a solution will be a bit redundant, but I have
no strong opinion on how to parse the interface name provided by the
user :)

BR,
Kristian