netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] netfilter: fix make target xt_TCPMSS.o error.
@ 2020-05-06  6:50 Huang Qijun
  2020-05-06  9:07 ` Jan Engelhardt
  2020-05-06 21:55 ` Cong Wang
  0 siblings, 2 replies; 3+ messages in thread
From: Huang Qijun @ 2020-05-06  6:50 UTC (permalink / raw)
  To: pablo
  Cc: kadlec, fw, davem, kuba, ast, daniel, kafai, songliubraving, yhs,
	andriin, john.fastabend, kpsingh, netfilter-devel, coreteam,
	netdev, linux-kernel, bpf, Huang Qijun

When compiling netfilter, there will be an error
"No rule to make target 'net/netfilter/xt_TCPMSS.o'",
because the xt_TCPMSS.c in the makefile is uppercase,
and the file name of the source file (xt_tcpmss.c) is lowercase.
Therefore, change the xt_TCPMSS.c name in the makefile to all lowercase.

Signed-off-by: Huang Qijun <dknightjun@gmail.com>
---
 net/netfilter/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/Makefile b/net/netfilter/Makefile
index 0e0ded87e27b..b974ade24556 100644
--- a/net/netfilter/Makefile
+++ b/net/netfilter/Makefile
@@ -157,7 +157,7 @@ obj-$(CONFIG_NETFILTER_XT_TARGET_REDIRECT) += xt_REDIRECT.o
 obj-$(CONFIG_NETFILTER_XT_TARGET_MASQUERADE) += xt_MASQUERADE.o
 obj-$(CONFIG_NETFILTER_XT_TARGET_SECMARK) += xt_SECMARK.o
 obj-$(CONFIG_NETFILTER_XT_TARGET_TPROXY) += xt_TPROXY.o
-obj-$(CONFIG_NETFILTER_XT_TARGET_TCPMSS) += xt_TCPMSS.o
+obj-$(CONFIG_NETFILTER_XT_TARGET_TCPMSS) += xt_tcpmss.o
 obj-$(CONFIG_NETFILTER_XT_TARGET_TCPOPTSTRIP) += xt_TCPOPTSTRIP.o
 obj-$(CONFIG_NETFILTER_XT_TARGET_TEE) += xt_TEE.o
 obj-$(CONFIG_NETFILTER_XT_TARGET_TRACE) += xt_TRACE.o
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] netfilter: fix make target xt_TCPMSS.o error.
  2020-05-06  6:50 [PATCH] netfilter: fix make target xt_TCPMSS.o error Huang Qijun
@ 2020-05-06  9:07 ` Jan Engelhardt
  2020-05-06 21:55 ` Cong Wang
  1 sibling, 0 replies; 3+ messages in thread
From: Jan Engelhardt @ 2020-05-06  9:07 UTC (permalink / raw)
  To: Huang Qijun
  Cc: pablo, kadlec, fw, davem, kuba, ast, daniel, kafai,
	songliubraving, yhs, andriin, john.fastabend, kpsingh,
	netfilter-devel, coreteam, netdev, linux-kernel, bpf

On Wednesday 2020-05-06 08:50, Huang Qijun wrote:

>When compiling netfilter, there will be an error
>"No rule to make target 'net/netfilter/xt_TCPMSS.o'",
>because the xt_TCPMSS.c in the makefile is uppercase,
>and the file name of the source file (xt_tcpmss.c) is lowercase.

>-obj-$(CONFIG_NETFILTER_XT_TARGET_TCPMSS) += xt_TCPMSS.o
>+obj-$(CONFIG_NETFILTER_XT_TARGET_TCPMSS) += xt_tcpmss.o

Uhm, no:

11:07 a4:../net/netfilter » ls -l xt_*[Mm][Ss]*.c
-rw-r--r-- 1 jengelh users 8948 Feb 27 09:30 xt_TCPMSS.c
-rw-r--r-- 1 jengelh users 2459 Feb 27 09:30 xt_tcpmss.c

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] netfilter: fix make target xt_TCPMSS.o error.
  2020-05-06  6:50 [PATCH] netfilter: fix make target xt_TCPMSS.o error Huang Qijun
  2020-05-06  9:07 ` Jan Engelhardt
@ 2020-05-06 21:55 ` Cong Wang
  1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2020-05-06 21:55 UTC (permalink / raw)
  To: Huang Qijun
  Cc: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
	David Miller, Jakub Kicinski, Alexei Starovoitov,
	Daniel Borkmann, Martin KaFai Lau, Song Liu, yhs,
	Andrii Nakryiko, John Fastabend, kpsingh, NetFilter, coreteam,
	Linux Kernel Network Developers, LKML, bpf

On Tue, May 5, 2020 at 11:52 PM Huang Qijun <dknightjun@gmail.com> wrote:
>
> When compiling netfilter, there will be an error
> "No rule to make target 'net/netfilter/xt_TCPMSS.o'",
> because the xt_TCPMSS.c in the makefile is uppercase,
> and the file name of the source file (xt_tcpmss.c) is lowercase.
> Therefore, change the xt_TCPMSS.c name in the makefile to all lowercase.

This is what you will get when you compile Linux kernel
on a case-insensitive filesystem like MacOS.

Please use a case-sensitive one.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-06 21:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06  6:50 [PATCH] netfilter: fix make target xt_TCPMSS.o error Huang Qijun
2020-05-06  9:07 ` Jan Engelhardt
2020-05-06 21:55 ` Cong Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).