Re: [PATCH iptables v1] iptables-test.py: fix python3

[shekhar sharma <shekhar250198@gmail.com>]

Hi,

On Mon, May 27, 2019 at 9:34 PM Phil Sutter <phil@nwl.cc> wrote:
>
> Hi,
>
> On Sat, May 25, 2019 at 01:32:06AM +0530, Shekhar Sharma wrote:
> > This patch converts the 'iptables-test.py' file (iptables/iptables-test.py) to run on
> > both python 2 and python3.
> >
> > Do we need to add an argument for 'version' in the argument parser?
>
> You should insert questions between the '---' marker below and the
> diffstat. This way they won't end up in the commit message.
>
Sorry, will write the questions like that from now on.


> Regarding your question: Assuming that iptables-test.py really is
> version agnostic, why should users care which interpreter version is
> used? Do you have a use-case in mind which justifies making the
> interpreter version selectable via parameter?
>

True.
I don't have a use-case in mind right now.

> [...]
> > @@ -79,7 +80,7 @@ def run_test(iptables, rule, rule_save, res, filename, lineno, netns):
> >
> >      cmd = iptables + " -A " + rule
> >      if netns:
> > -            cmd = "ip netns exec ____iptables-container-test " + EXECUTEABLE + " " + cmd
> > +            cmd = "ip netns exec ____iptables-container-test " + EXECUTEABLE + "  {}".format(cmd)
>
> Please respect the max column limit of 80 characters, even if the old
> code exceeded it already.
>
Sorry, will correct it.

> Thanks, Phil

Thank you for your comments!
Shekhar