From: Arturo Borrero Gonzalez <arturo@netfilter.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Netfilter Development Mailing list <netfilter-devel@vger.kernel.org>
Subject: Re: [nft PATCH] nft: rearrange help output to group related options together
Date: Sun, 26 Jul 2020 15:34:09 +0200 [thread overview]
Message-ID: <CAOkSjBhapST_3CX_Ain61KAdcvb1uHArH8U9FV_dATS8sBfS2A@mail.gmail.com> (raw)
In-Reply-To: <20200724104333.GA22517@salvia>
On Fri, 24 Jul 2020 at 12:43, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>
> Hi Arturo,
>
> On Thu, Jul 23, 2020 at 12:38:09PM +0200, Arturo Borrero Gonzalez wrote:
> [...]
> > After this patch, the help output is:
> >
> > === 8< ===
> > % nft --help
> > Usage: nft [ options ] [ cmds... ]
> >
> > Options (general):
> > -h, help Show this help
> > -v, version Show version information
> > -V Show extended version information
> >
> > Options (with operative meaning):
> > -c, check Check commands validity without actually applying the changes.
> > -f, file <filename> Read input from <filename>
> > -i, interactive Read input from interactive CLI
> > -I, includepath <directory> Add <directory> to the paths searched for include files. Defaul[..]
> >
> > Options (output text modifiers for data translation):
> >
> > -N, reversedns Translate IP addresses to names.
> > -S, service Translate ports to service names as described in /etc/services.
> > -u, guid Print UID/GID as defined in /etc/passwd and /etc/group.
> > -n, numeric Print fully numerical output.
> > -y, numeric-priority Print chain priority numerically.
> > -p, numeric-protocol Print layer 4 protocols numerically.
> > -T, numeric-time Print time values numerically.
> >
> > Options (output text modifiers for parsing and other operations):
> > -d, debug <level [,level...]> Specify debugging level (scanner, parser, eval, netlink, mnl, p[..]
> > -e, echo Echo what has been added, inserted or replaced.
> > -s, stateless Omit stateful information of ruleset.
> > -a, handle Output rule handle.
> > -j, json Format output in JSON
> > -t, terse Omit contents of sets.
> > === 8< ===
>
> My proposal:
>
> % nft --help
> Usage: nft [ options ] [ cmds... ]
>
> Options (general):
> -h, help Show this help
> -v, version Show version information
> -V Show extended version information
>
> Options (ruleset input handling):
> -f, file <filename> Read input from <filename>
> -i, interactive Read input from interactive CLI
> -I, includepath <directory> Add <directory> to the paths searched for include files. Defaul[..]
> -c, check Check commands validity without actually applying the changes.
>
> Options (ruleset list formatting):
> -a, handle Output rule handle.
> -s, stateless Omit stateful information of ruleset.
> -t, terse Omit contents of sets.
> -S, service Translate ports to service names as described in /etc/services.
> -N, reversedns Translate IP addresses to names.
> -u, guid Print UID/GID as defined in /etc/passwd and /etc/group.
> -n, numeric Print fully numerical output.
> -y, numeric-priority Print chain priority numerically.
> -p, numeric-protocol Print layer 4 protocols numerically.
> -T, numeric-time Print time values numerically.
>
> Options (command output format):
> -e, echo Echo what has been added, inserted or replaced.
> -j, json Format output in JSON
> -d, debug <level [,level...]> Specify debugging level (scanner, parser, eval, netlink, mnl, p[..]
That's OK.
I'm AFK, could you please amend and push the patch?
regards.
prev parent reply other threads:[~2020-07-26 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 10:38 [nft PATCH] nft: rearrange help output to group related options together Arturo Borrero Gonzalez
2020-07-24 10:43 ` Pablo Neira Ayuso
2020-07-26 13:34 ` Arturo Borrero Gonzalez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOkSjBhapST_3CX_Ain61KAdcvb1uHArH8U9FV_dATS8sBfS2A@mail.gmail.com \
--to=arturo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).