From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5704CC678D4 for ; Wed, 1 Mar 2023 22:28:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbjCAW2k (ORCPT ); Wed, 1 Mar 2023 17:28:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbjCAW2k (ORCPT ); Wed, 1 Mar 2023 17:28:40 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 850C72333A for ; Wed, 1 Mar 2023 14:28:39 -0800 (PST) Date: Wed, 1 Mar 2023 23:28:36 +0100 From: Pablo Neira Ayuso To: Phil Sutter Cc: Jozsef Kadlecsik , netfilter-devel@vger.kernel.org Subject: Re: [ipset PATCH 0/2] Two minor code fixes Message-ID: References: <20230222170241.26208-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230222170241.26208-1-phil@nwl.cc> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Feb 22, 2023 at 06:02:39PM +0100, Phil Sutter wrote: > These were identified by Coverity tool, no problems in practice. Still > worth fixing to reduce noise in code checkers. LGTM. Did you run ipset xlate tests? These should not break those but just in case.