From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E6BC433F5 for ; Tue, 21 Sep 2021 01:55:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 535B6610A8 for ; Tue, 21 Sep 2021 01:55:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236231AbhIUB5Q (ORCPT ); Mon, 20 Sep 2021 21:57:16 -0400 Received: from mail.netfilter.org ([217.70.188.207]:39654 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237212AbhIUBww (ORCPT ); Mon, 20 Sep 2021 21:52:52 -0400 Received: from netfilter.org (unknown [78.30.35.141]) by mail.netfilter.org (Postfix) with ESMTPSA id 081FF63EB2; Tue, 21 Sep 2021 03:50:06 +0200 (CEST) Date: Tue, 21 Sep 2021 03:51:21 +0200 From: Pablo Neira Ayuso To: Florian Westphal Cc: netfilter-devel@vger.kernel.org, youling 257 Subject: Re: [PATCH nf] netfilter: iptable_raw: drop bogus net_init annotation Message-ID: References: <20210917095625.1338-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210917095625.1338-1-fw@strlen.de> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Fri, Sep 17, 2021 at 11:56:25AM +0200, Florian Westphal wrote: > This is a leftover from the times when this function was wired up via > pernet_operations. Now its called when userspace asks for the table. > > With CONFIG_NET_NS=n, iptable_raw_table_init memory has been discarded > already and we get a kernel crash. > > Other tables are fine, __net_init annotation was removed already. Applied, thanks.