From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BEF9ECAAD4 for ; Wed, 31 Aug 2022 23:52:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229631AbiHaXwE (ORCPT ); Wed, 31 Aug 2022 19:52:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbiHaXwD (ORCPT ); Wed, 31 Aug 2022 19:52:03 -0400 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1D2A1F14F0 for ; Wed, 31 Aug 2022 16:52:02 -0700 (PDT) Date: Thu, 1 Sep 2022 01:51:58 +0200 From: Pablo Neira Ayuso To: David Leadbeater Cc: Jozsef Kadlecsik , Florian Westphal , netfilter-devel@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH 2/2] netfilter: nf_conntrack_irc: Fix forged IP logic Message-ID: References: <20220826045658.100360-1-dgl@dgl.cx> <20220826045658.100360-2-dgl@dgl.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220826045658.100360-2-dgl@dgl.cx> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Fri, Aug 26, 2022 at 02:56:58PM +1000, David Leadbeater wrote: > Ensure the match happens in the right direction, previously the > destination used was the server, not the NAT host, as the comment > shows the code intended. > > Additionally nf_nat_irc uses port 0 as a signal and there's no valid way > it can appear in a DCC message, so consider port 0 also forged. Applied, thanks