From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] evaluate: un-break rule insert with intervals
Date: Tue, 20 Sep 2022 15:20:03 +0200 [thread overview]
Message-ID: <Yym+A27DQyryYtwE@salvia> (raw)
In-Reply-To: <20220920125726.5818-1-fw@strlen.de>
On Tue, Sep 20, 2022 at 02:57:26PM +0200, Florian Westphal wrote:
> 'rule inet dscpclassify dscp_match meta l4proto { udp } th dport { 3478 } th sport { 3478-3497, 16384-16387 } goto ct_set_ef'
> works with 'nft add', but not 'nft insert', the latter yields: "BUG: unhandled op 4".
That's my fault, thanks for the fix.
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
P.S: Please add a simple test for this regression.
> Fixes: 81e36530fcac ("src: replace interval segment tree overlap and automerge")
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> src/evaluate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/evaluate.c b/src/evaluate.c
> index d9c9ca28a53a..edebd7bcd8ab 100644
> --- a/src/evaluate.c
> +++ b/src/evaluate.c
> @@ -1520,6 +1520,7 @@ static int interval_set_eval(struct eval_ctx *ctx, struct set *set,
> switch (ctx->cmd->op) {
> case CMD_CREATE:
> case CMD_ADD:
> + case CMD_INSERT:
> if (set->automerge) {
> ret = set_automerge(ctx->msgs, ctx->cmd, set, init,
> ctx->nft->debug_mask);
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-09-20 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 12:57 [PATCH nft] evaluate: un-break rule insert with intervals Florian Westphal
2022-09-20 13:20 ` Pablo Neira Ayuso [this message]
2022-09-20 13:27 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yym+A27DQyryYtwE@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).