From: Arturo Borrero Gonzalez <arturo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org, eric@regit.org,
Chris Boot <bootc@debian.org>,
myon@debian.org
Subject: Re: [PATCH] build: adjust configure for postgresql 11
Date: Fri, 22 Mar 2019 10:04:21 +0100 [thread overview]
Message-ID: <a377fcf6-8940-34de-b1d6-0de07f10e046@netfilter.org> (raw)
In-Reply-To: <20190321115456.24137-1-jengelh@inai.de>
On 3/21/19 12:54 PM, Jan Engelhardt wrote:
> At least in openSUSE, PostgreSQL 11 no longer ships the pg_config
> program. Instead, there is has been a pkg-config file around for a
> while (also in pg10), so make use of that, by default.
>
> The old --with-pgsql-inc and --with-pgsql-lib option are going away
> and replaced by the standardized mechanisms pkg-config.m4 has in
> store for when there is no .pc file:
>
> ./configure pgsql_CFLAGS="-I/opt/pgsql/include" \
> pgsql_LIBS="-L/opt/pgsql/lib -lpq"
> ---
> acinclude.m4 | 77 +---------------------------------------
> configure.ac | 9 +++--
> output/pgsql/Makefile.am | 4 +--
> 3 files changed, 7 insertions(+), 83 deletions(-)
>
Debian ships pg_config. In fact, the same package libpq-dev [0] contains both
things:
* /usr/bin/pg_config
* /usr/lib/x86_64-linux-gnu/pkgconfig/libpq.pc
So I think this patch should be fine.
Acked-by: Arturo Borrero Gonzalez <arturo@netfilter.org>
[0] https://packages.debian.org/sid/amd64/libpq-dev/filelist
next prev parent reply other threads:[~2019-03-22 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 11:54 [PATCH] build: adjust configure for postgresql 11 Jan Engelhardt
2019-03-21 12:25 ` [PATCH] build: adjust configure for postgresql 10/11 Jan Engelhardt
2019-03-22 9:04 ` Arturo Borrero Gonzalez [this message]
2019-03-22 12:55 ` [PATCH] build: adjust configure for postgresql 11 Jan Engelhardt
2019-03-22 13:23 ` Christoph Berg
2019-04-08 21:43 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a377fcf6-8940-34de-b1d6-0de07f10e046@netfilter.org \
--to=arturo@netfilter.org \
--cc=bootc@debian.org \
--cc=eric@regit.org \
--cc=jengelh@inai.de \
--cc=myon@debian.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).