From: Eric Dumazet <eric.dumazet@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
Lukas Wunner <lukas@wunner.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Eric Dumazet <edumazet@google.com>, Thomas Graf <tgraf@suug.ch>,
Laura Garcia <nevola@gmail.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH nf-next v3 0/3] Netfilter egress hook
Date: Fri, 28 Aug 2020 11:14:25 +0200 [thread overview]
Message-ID: <a9006cf7-f4ba-81b1-fca1-fd2e97939fdc@gmail.com> (raw)
In-Reply-To: <454130d7-7256-838d-515e-c7340892278c@iogearbox.net>
On 8/28/20 12:14 AM, Daniel Borkmann wrote:
> Hi Lukas,
>
> On 8/27/20 10:55 AM, Lukas Wunner wrote:
>> Introduce a netfilter egress hook to allow filtering outbound AF_PACKETs
>> such as DHCP and to prepare for in-kernel NAT64/NAT46.
>
> Thinking more about this, how will this allow to sufficiently filter AF_PACKET?
> It won't. Any AF_PACKET application can freely set PACKET_QDISC_BYPASS without
> additional privileges and then dev_queue_xmit() is being bypassed in the host ns.
> This is therefore ineffective and not sufficient. (From container side these can
> be caught w/ host veth on ingress, but not in host ns, of course, so hook won't
> be invoked.)
Presumably dev_direct_xmit() could be augmented to support the hook.
dev_direct_xmit() (packet_direct_xmit()) was introduced to bypass qdisc,
not to bypass everything.
prev parent reply other threads:[~2020-08-28 9:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 8:55 [PATCH nf-next v3 0/3] Netfilter egress hook Lukas Wunner
2020-08-27 8:55 ` [PATCH nf-next v3 1/3] netfilter: Rename ingress hook include file Lukas Wunner
2020-08-27 8:55 ` [PATCH nf-next v3 2/3] netfilter: Generalize ingress hook Lukas Wunner
2020-08-27 8:55 ` [PATCH nf-next v3 3/3] netfilter: Introduce egress hook Lukas Wunner
2020-08-28 18:52 ` John Fastabend
2020-09-03 5:00 ` John Fastabend
2020-09-04 8:54 ` Laura García Liébana
2020-09-04 15:46 ` John Fastabend
2020-09-05 11:13 ` Laura García Liébana
2020-09-04 16:21 ` Lukas Wunner
2020-09-04 21:14 ` Daniel Borkmann
2020-09-05 5:24 ` Lukas Wunner
2020-09-08 12:55 ` Daniel Borkmann
2020-09-11 7:42 ` Laura García Liébana
2020-09-11 16:27 ` Daniel Borkmann
2020-09-14 11:29 ` Laura García Liébana
2020-09-14 22:02 ` Daniel Borkmann
2020-09-17 10:28 ` Laura García Liébana
2020-09-18 20:31 ` Daniel Borkmann
2020-09-19 15:52 ` Pablo Neira Ayuso
2020-09-21 7:07 ` Laura García Liébana
2020-10-11 8:26 ` Lukas Wunner
2020-11-21 18:59 ` Pablo Neira Ayuso
2020-11-22 3:24 ` Alexei Starovoitov
2020-11-22 11:01 ` Pablo Neira Ayuso
2020-11-24 3:34 ` Alexei Starovoitov
2020-11-24 7:31 ` Lukas Wunner
2020-11-24 22:55 ` Alexei Starovoitov
2020-10-11 7:59 ` Lukas Wunner
2020-09-05 11:18 ` Laura García Liébana
2020-09-07 22:11 ` Daniel Borkmann
2020-09-08 6:19 ` Laura García Liébana
2020-09-08 11:46 ` Arturo Borrero Gonzalez
2020-09-08 13:27 ` Daniel Borkmann
2020-09-08 18:58 ` John Fastabend
2020-09-19 15:54 ` Pablo Neira Ayuso
2020-09-28 12:20 ` Lukas Wunner
2020-08-27 10:36 ` [PATCH nf-next v3 0/3] Netfilter " Laura García Liébana
2020-08-28 7:14 ` Daniel Borkmann
2020-08-28 9:14 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9006cf7-f4ba-81b1-fca1-fd2e97939fdc@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=ast@kernel.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nevola@gmail.com \
--cc=pablo@netfilter.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).