From: "Kadlecsik József" <kadlec@blackhole.kfki.hu>
To: Hillf Danton <hdanton@sina.com>
Cc: syzbot <syzbot+68a806795ac89df3aa1c@syzkaller.appspotmail.com>,
x86@kernel.org, tony.luck@intel.com, peterz@infradead.org,
netdev@vger.kernel.org, hpa@zytor.com,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
coreteam@netfilter.org, bp@alien8.de,
netfilter-devel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, davem@davemloft.net
Subject: Re: [netfilter-core] INFO: rcu detected stall in hash_ip4_gc
Date: Tue, 28 Jan 2020 09:53:45 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.2001280948480.5190@blackhole.kfki.hu> (raw)
In-Reply-To: <20200128022601.15116-1-hdanton@sina.com>
On Tue, 28 Jan 2020, Hillf Danton wrote:
>
> On Mon, 27 Jan 2020 23:14:03 +0100 (CET) Kadlecsik Jozsef wrote:
> >
> > Thanks for the patch, but it does not fix completely the issue: the same
> > error message can pop up in ip_set_uadd(), because it calls the gc
> > function as well when the set is full but there can be timed out entries.
>
> Why is trylock-based gc going to make hassle again?
Because mtype_expire() which scans the whole set to find and evict
expired entries is called not only from the gc function but from add as
well (to reclaim space since last gc) and list too (to get the number of
elements). One locks out the another and that reported in the error
message.
> > I'm going to work on a solution with covers that case too.
Region-locking seems to be the best way to go.
Best regards,
Jozsef
-
E-mail : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics
H-1525 Budapest 114, POB. 49, Hungary
prev parent reply other threads:[~2020-01-28 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200127042315.10456-1-hdanton@sina.com>
2020-01-27 22:14 ` [netfilter-core] INFO: rcu detected stall in hash_ip4_gc Kadlecsik József
[not found] ` <20200128022601.15116-1-hdanton@sina.com>
2020-01-28 8:53 ` Kadlecsik József [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.2001280948480.5190@blackhole.kfki.hu \
--to=kadlec@blackhole.kfki.hu \
--cc=bp@alien8.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=hdanton@sina.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=syzbot+68a806795ac89df3aa1c@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).