From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91441C38145 for ; Tue, 6 Sep 2022 06:57:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233238AbiIFG5U (ORCPT ); Tue, 6 Sep 2022 02:57:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232367AbiIFG5S (ORCPT ); Tue, 6 Sep 2022 02:57:18 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20F7D72B78 for ; Mon, 5 Sep 2022 23:57:16 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id t7so8925485wrm.10 for ; Mon, 05 Sep 2022 23:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:from:to:cc:subject:date; bh=zFJWGExBh7/ejgjCjzUqnrQxgOzG1QD0QttqPTjMDxQ=; b=NZJ4oojOYQ/ZIa7B8gf8BbGTK55vYZuNrhTX2zcxHensQZ2mTDPG14XOg71Lxnb0Gx XPS7rERLRuh3ZbcG5jSmiFEObloOChr3Qcwd8AG8Ns5L/IfRQrdM4TSSdtfCVzuZmI21 GZ0cQmEYTrQzthcSDtb41mmm3pdXlt+swjcDfLn3p1RArD5ubjkfDplrBLvZfOArlL1U FA9VTB+jQ7Je1IruzrpmWQJPkhv3mMVNJLAq5lSByNepxZBjo3mJY1HEs2xvfiJ766PF oUNcRGj7hFf2+k87SH3rW/48UpDYaWEdiDP3/fBaeVqxoz1CtPsPIdW/9OaulJRiTAWU 5g7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date; bh=zFJWGExBh7/ejgjCjzUqnrQxgOzG1QD0QttqPTjMDxQ=; b=kUR+BoI/DHoPVW0ql9vFRltf6JCru67khge7ZAQsjwh3oItCEzoHadPrwvgJ8PbUxI lP3sqHlQKQgnVqkDz8vPe3BElTdPJQONQnmZlw8DafTUR5SUKX4tBLz6lwaHQehURPXU 1GOwm005JENS4M+6SB92TC0yJ9rbNElMU8c7w0XRvTzBmhwozxrA0TFp36nNHs7EjGg3 C3K0EZ0vrNx+MnNfynIgI7Vm0kToCHe3XfSyx0ZEVWyhg+yzAcRBMaV5GybT6/D0a9rm xfQqAS8BYM2A6OtoGBedLZxg1KwA5Vk+XFeF42bthnDShCP+hX3IktpX1QwQMgbnoghL jbCA== X-Gm-Message-State: ACgBeo1tWsoDmInZW2RSwWannyG9HoQyxXR/dC0ZLVp65me1gXeZU/0I gC/pYFEbW1aFbIcrYq/kp8FQSxjBVj+0tQ== X-Google-Smtp-Source: AA6agR7ESdke6b+0DY38mxHAxbvmmu0p+zpwwQ0e6ficvAoaU6+ZeBW6No9OyjI24p5tD5JUyqwLDQ== X-Received: by 2002:a5d:4805:0:b0:228:db70:6641 with SMTP id l5-20020a5d4805000000b00228db706641mr346081wrq.377.1662447434487; Mon, 05 Sep 2022 23:57:14 -0700 (PDT) Received: from ?IPV6:2a01:e0a:b41:c160:68b7:cde8:77c2:4bde? ([2a01:e0a:b41:c160:68b7:cde8:77c2:4bde]) by smtp.gmail.com with ESMTPSA id e2-20020a5d5942000000b00226f39d1a3esm11261015wri.73.2022.09.05.23.57.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 23:57:13 -0700 (PDT) Message-ID: Date: Tue, 6 Sep 2022 08:57:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH nf-next] netfilter: nf_tables: add ebpf expression Content-Language: en-US To: Florian Westphal , Alexei Starovoitov Cc: Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , "David S. Miller" , Jakub Kicinski , Network Development , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , netfilter-devel , bpf References: <20220831101617.22329-1-fw@strlen.de> <87v8q84nlq.fsf@toke.dk> <20220831125608.GA8153@breakpoint.cc> <87o7w04jjb.fsf@toke.dk> <20220831135757.GC8153@breakpoint.cc> <87ilm84goh.fsf@toke.dk> <20220831152624.GA15107@breakpoint.cc> <20220831155341.GC15107@breakpoint.cc> <20220831215737.GE15107@breakpoint.cc> From: Nicolas Dichtel Organization: 6WIND In-Reply-To: <20220831215737.GE15107@breakpoint.cc> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Le 31/08/2022 à 23:57, Florian Westphal a écrit : > Alexei Starovoitov wrote: >>> This helps gradually moving towards move epbf for those that >>> still heavily rely on the classic forwarding path. >> >> No one is using it. >> If it was, we would have seen at least one bug report over >> all these years. We've seen none. > > Err, it IS used, else I would not have sent this patch. > >> very reasonable early on and turned out to be useless with >> zero users. >> BPF_PROG_TYPE_SCHED_ACT and BPF_PROG_TYPE_LWT* >> are in this category. > > I doubt it had 0 users. Those users probably moved to something > better? We are using BPF_PROG_TYPE_SCHED_ACT to perform custom encapsulations. What could we used to replace that?