From: Edward Cree <ecree@solarflare.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <netfilter-devel@vger.kernel.org>,
<jiri@resnulli.us>, <kuba@kernel.org>, <pablo@netfilter.org>
Subject: Re: [PATCH v3 net-next] net: flow_offload: simplify hw stats check handling
Date: Wed, 20 May 2020 18:31:05 +0100 [thread overview]
Message-ID: <f2586a0e-fce1-cee9-e2dc-f3dc73500515@solarflare.com> (raw)
In-Reply-To: <2cf9024d-1568-4594-5763-6c4e4e8fe47b@solarflare.com>
On 20/05/2020 18:21, Edward Cree wrote:
> @@ -582,7 +590,7 @@ nf_flow_offload_rule_alloc(struct net *net,
> const struct flow_offload_tuple *tuple;
> struct nf_flow_rule *flow_rule;
> struct dst_entry *other_dst;
> - int err = -ENOMEM;
> + int err = -ENOMEM, i;
>
> flow_rule = kzalloc(sizeof(*flow_rule), GFP_KERNEL);
> if (!flow_rule)
Whoops, this changebar isn't meant to be there. Somehow I missed
the unused var warning when I built it, too.
Drop this, I'll spin v4.
next prev parent reply other threads:[~2020-05-20 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 17:21 [PATCH v3 net-next] net: flow_offload: simplify hw stats check handling Edward Cree
2020-05-20 17:31 ` Edward Cree [this message]
2020-05-20 17:32 ` Pablo Neira Ayuso
2020-05-20 17:52 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2586a0e-fce1-cee9-e2dc-f3dc73500515@solarflare.com \
--to=ecree@solarflare.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).