From: Lyude Paul <lyude@redhat.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Jani Nikula" <jani.nikula@intel.com>
Cc: David Airlie <airlied@linux.ie>,
nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
open list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, greg.depoire@gmail.com,
Sean Paul <seanpaul@chromium.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [Nouveau] [Intel-gfx] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers
Date: Fri, 19 Feb 2021 16:14:14 -0500 [thread overview]
Message-ID: <1755ae053e78a1f0eea1789f84e6206777eb46ac.camel@redhat.com> (raw)
In-Reply-To: <YC6IZ+BUcA5uDCej@intel.com>
On Thu, 2021-02-18 at 17:31 +0200, Ville Syrjälä wrote:
> On Thu, Feb 18, 2021 at 10:35:05AM +0200, Jani Nikula wrote:
> > On Fri, 12 Feb 2021, Lyude Paul <lyude@redhat.com> wrote:
> > > I think it wouldn't be a bad idea to just address this with a followup
> > > series
> > > instead and use the old DRM_DEBUG_* macros in the mean time.
> >
> > aux->dev is there, could also use dev_dbg et al. in the mean time. They
> > handle NULL dev gracefully too if the driver didn't set that.
>
> Last I looked aux->dev was random. Some drivers point it at the
> connector vs. some at the the pci/platform device.
>
That's correct-for most SoCs the AUX channel is actually a standalone platform
device that isn't associated with the DRM device by default. /But/ I went
through the tree yesterday and the day before and did a bunch of cleanup around
DP aux registration, added a drm_dev field and hooked it up in every driver with
an aux channel, and then converted all of the DP helpers (including dual mode
and MST) over to using drm_dbg_*() variants. Once I've gotten through reading
all my email for today I'm going to do a quick sanity check on it and then post
the series to dri-devel.
--
Sincerely,
Lyude Paul (she/her)
Software Engineer at Red Hat
Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
next prev parent reply other threads:[~2021-02-19 21:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 23:38 [Nouveau] [RFC v4 00/11] drm: Extract DPCD backlight helpers from i915, add support in nouveau Lyude Paul
2021-02-08 23:38 ` [Nouveau] [RFC v4 01/11] drm/nouveau/kms/nv40-/backlight: Assign prop type once Lyude Paul
2021-02-08 23:38 ` [Nouveau] [RFC v4 02/11] drm/nouveau/kms: Don't probe eDP connectors more then once Lyude Paul
2021-02-08 23:38 ` [Nouveau] [RFC v4 03/11] drm/i915/dpcd_bl: Remove redundant AUX backlight frequency calculations Lyude Paul
2021-02-08 23:38 ` [Nouveau] [RFC v4 04/11] drm/i915/dpcd_bl: Handle drm_dpcd_read/write() return values correctly Lyude Paul
2021-02-08 23:38 ` [Nouveau] [RFC v4 05/11] drm/i915/dpcd_bl: Cleanup intel_dp_aux_vesa_enable_backlight() a bit Lyude Paul
2021-02-11 3:56 ` Rodrigo Vivi
2021-02-12 11:28 ` Jani Nikula
2021-02-08 23:38 ` [Nouveau] [RFC v4 06/11] drm/i915/dpcd_bl: Cache some backlight capabilities in intel_panel.backlight Lyude Paul
2021-02-08 23:38 ` [Nouveau] [RFC v4 07/11] drm/i915/dpcd_bl: Move VESA backlight enabling code closer together Lyude Paul
2021-02-08 23:38 ` [Nouveau] [RFC v4 08/11] drm/i915/dpcd_bl: Return early in vesa_calc_max_backlight if we can't read PWMGEN_BIT_COUNT Lyude Paul
2021-02-11 3:52 ` [Nouveau] [Intel-gfx] " Rodrigo Vivi
2021-02-08 23:38 ` [Nouveau] [RFC v4 09/11] drm/i915/dpcd_bl: Print return codes for VESA backlight failures Lyude Paul
2021-02-11 3:47 ` [Nouveau] [Intel-gfx] " Rodrigo Vivi
2021-02-08 23:39 ` [Nouveau] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers Lyude Paul
2021-02-11 4:15 ` [Nouveau] [Intel-gfx] " Rodrigo Vivi
2021-02-11 18:35 ` Lyude Paul
2021-02-12 22:15 ` Lyude Paul
2021-02-18 8:35 ` Jani Nikula
2021-02-18 15:31 ` Ville Syrjälä
2021-02-19 21:14 ` Lyude Paul [this message]
2021-02-08 23:39 ` [Nouveau] [RFC v4 11/11] drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1755ae053e78a1f0eea1789f84e6206777eb46ac.camel@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=greg.depoire@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=seanpaul@chromium.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).