From: Lyude <lyude@redhat.com>
To: nouveau@lists.freedesktop.org, igt-dev@lists.freedesktop.org
Subject: [Nouveau] [PATCH i-g-t 4/7] lib/igt_fb: Remove domain from igt_fb
Date: Wed, 17 Mar 2021 18:49:46 -0400 [thread overview]
Message-ID: <20210317224949.448284-5-lyude@redhat.com> (raw)
In-Reply-To: <20210317224949.448284-1-lyude@redhat.com>
From: Lyude Paul <lyude@redhat.com>
It doesn't look like that this is used by i915 for anything these days, so
let's just remove this while we're at it.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Martin Peres <martin.peres@free.fr>
Cc: Jeremy Cline <jcline@redhat.com>
---
lib/igt_fb.c | 3 ---
lib/igt_fb.h | 2 --
2 files changed, 5 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index f0fcd1a7..2b478887 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -2491,7 +2491,6 @@ static void create_cairo_surface__gpu(int fd, struct igt_fb *fb)
cairo_format,
fb->width, fb->height,
blit->linear.fb.strides[0]);
- fb->domain = I915_GEM_DOMAIN_GTT;
cairo_surface_set_user_data(fb->cairo_surface,
(cairo_user_data_key_t *)create_cairo_surface__gpu,
@@ -2571,8 +2570,6 @@ static void create_cairo_surface__gtt(int fd, struct igt_fb *fb)
"Unable to create a cairo surface: %s\n",
cairo_status_to_string(cairo_surface_status(fb->cairo_surface)));
- fb->domain = I915_GEM_DOMAIN_GTT;
-
cairo_surface_set_user_data(fb->cairo_surface,
(cairo_user_data_key_t *)create_cairo_surface__gtt,
fb, destroy_cairo_surface__gtt);
diff --git a/lib/igt_fb.h b/lib/igt_fb.h
index 0d64898a..e4f8b2b1 100644
--- a/lib/igt_fb.h
+++ b/lib/igt_fb.h
@@ -64,7 +64,6 @@ struct buf_ops;
* @modifier: tiling mode as a DRM framebuffer modifier
* @size: size in bytes of the underlying backing storage
* @cairo_surface: optionally attached cairo drawing surface
- * @domain: current domain for cache flushing tracking on i915.ko
* @num_planes: Amount of planes on this fb. >1 for planar formats.
* @strides: line stride for each plane in bytes
* @offsets: Offset for each plane in bytes.
@@ -87,7 +86,6 @@ typedef struct igt_fb {
uint64_t modifier;
uint64_t size;
cairo_surface_t *cairo_surface;
- unsigned int domain;
unsigned int num_planes;
uint32_t strides[4];
uint32_t offsets[4];
--
2.29.2
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
next prev parent reply other threads:[~2021-03-17 22:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 22:49 [Nouveau] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Lyude
2021-03-17 22:49 ` [Nouveau] [PATCH i-g-t 1/7] lib/drmtest: Use igt_assert_eq() for do_or_die() Lyude
2021-03-18 9:32 ` [Nouveau] [igt-dev] " Petri Latvala
2021-03-17 22:49 ` [Nouveau] [PATCH i-g-t 2/7] lib/drmtest: And use do_or_die() in do_ioctl() Lyude
2021-03-17 22:49 ` [Nouveau] [PATCH i-g-t 3/7] lib/drmtest: Remove i915 refs in do_ioctl*() docs Lyude
2021-03-17 22:49 ` Lyude [this message]
2021-03-18 12:49 ` [Nouveau] [igt-dev] [PATCH i-g-t 4/7] lib/igt_fb: Remove domain from igt_fb Ville Syrjälä
2021-03-17 22:49 ` [Nouveau] [PATCH i-g-t 5/7] lib/debugfs: Fix igt_crc_t docs to mention has_valid_frame Lyude
2021-03-17 22:49 ` [Nouveau] [PATCH i-g-t 6/7] lib/igt_aux: Print name of debug var in igt_debug_wait_for_keypress() Lyude
2021-03-17 22:49 ` [Nouveau] [PATCH i-g-t 7/7] lib/debugfs: Fix function name in igt_pipe_crc_get_for_frame() docs Lyude
2021-03-18 6:48 ` [Nouveau] [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Martin Peres
2021-03-18 9:38 ` Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317224949.448284-5-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).